mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

virtio-scsi-test: Test writing to scsi-cd device

Browse Source 
This tests that trying to write to a (read-only) scsi-cd device backed
by a read-write image file doesn't crash and results in the correct
error.

This is a regression test for https://bugs.launchpad.net/bugs/1906693.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20210118123448.307825-3-kwolf@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
Kevin Wolf 2021-01-18 13:34:48 +01:00
parent 86b1cf3227
commit 720d10d67b
1 changed files with 39 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
tests/qtest/virtio-scsi-test.c
View File

@ -200,6 +200,32 @@ static void test_unaligned_write_same(void *obj, void *data,
qvirtio_scsi_pci_free(vs); qvirtio_scsi_pci_free(vs);
} }
static void test_write_to_cdrom(void *obj, void *data,
QGuestAllocator *t_alloc)
{
QVirtioSCSI *scsi = obj;
QVirtioSCSIQueues *vs;
uint8_t buf[2048] = { 0 };
const uint8_t write_cdb[VIRTIO_SCSI_CDB_SIZE] = {
/* WRITE(10) to LBA 0, transfer length 1 */
0x2a, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00
};
struct virtio_scsi_cmd_resp resp;
alloc = t_alloc;
vs = qvirtio_scsi_init(scsi->vdev);
virtio_scsi_do_command(vs, write_cdb, NULL, 0, buf, 2048, &resp);
g_assert_cmphex(resp.response, ==, 0);
g_assert_cmphex(resp.status, ==, CHECK_CONDITION);
g_assert_cmphex(resp.sense[0], ==, 0x70);
g_assert_cmphex(resp.sense[2], ==, DATA_PROTECT);
g_assert_cmphex(resp.sense[12], ==, 0x27); /* WRITE PROTECTED */
g_assert_cmphex(resp.sense[13], ==, 0x00); /* WRITE PROTECTED */
qvirtio_scsi_pci_free(vs);
}
static void test_iothread_attach_node(void *obj, void *data, static void test_iothread_attach_node(void *obj, void *data,
QGuestAllocator *t_alloc) QGuestAllocator *t_alloc)
{ {
@ -267,6 +293,16 @@ static void *virtio_scsi_setup(GString *cmd_line, void *arg)
return arg; return arg;
} }
static void *virtio_scsi_setup_cd(GString *cmd_line, void *arg)
{
g_string_append(cmd_line,
" -drive file=null-co://,"
"file.read-zeroes=on,"
"if=none,id=dr1,format=raw "
"-device scsi-cd,drive=dr1,lun=0,scsi-id=1");
return arg;
}
static void *virtio_scsi_setup_iothread(GString *cmd_line, void *arg) static void *virtio_scsi_setup_iothread(GString *cmd_line, void *arg)
{ {
g_string_append(cmd_line, g_string_append(cmd_line,
@ -287,6 +323,9 @@ static void register_virtio_scsi_test(void)
qos_add_test("unaligned-write-same", "virtio-scsi", qos_add_test("unaligned-write-same", "virtio-scsi",
test_unaligned_write_same, &opts); test_unaligned_write_same, &opts);
opts.before = virtio_scsi_setup_cd;
qos_add_test("write-to-cdrom", "virtio-scsi", test_write_to_cdrom, &opts);
opts.before = virtio_scsi_setup_iothread; opts.before = virtio_scsi_setup_iothread;
opts.edge = (QOSGraphEdgeOptions) { opts.edge = (QOSGraphEdgeOptions) {
.extra_device_opts = "iothread=thread0", .extra_device_opts = "iothread=thread0",