mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hw/sd/sdcard: Send NUM_WR_BLOCKS bits MSB first (ACMD22)

Browse Source 
Per sections 3.6.1 (SD Bus Protocol), 4.3.4 "Data Write"
and 7.3.2 (Responses):

  In the CMD line the Most Significant Bit is transmitted first.

Use the stl_be_p() helper to store the value in big-endian.

Fixes: a1bb27b1e9 ("Initial SD card emulation")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Cédric Le Goater <clg@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20240628070216.92609-9-philmd@linaro.org>
This commit is contained in:
Philippe Mathieu-Daudé 2024-06-14 15:28:10 +02:00
parent e55cbe727b
commit 7028187bd0
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hw/sd/sd.c
View File

@ -1669,8 +1669,7 @@ static sd_rsp_type_t sd_app_command(SDState *sd,
case 22: /* ACMD22: SEND_NUM_WR_BLOCKS */ case 22: /* ACMD22: SEND_NUM_WR_BLOCKS */
switch (sd->state) { switch (sd->state) {
case sd_transfer_state: case sd_transfer_state:
*(uint32_t *) sd->data = sd->blk_written; stl_be_p(sd->data, sd->blk_written);
sd->state = sd_sendingdata_state; sd->state = sd_sendingdata_state;
sd->data_start = 0; sd->data_start = 0;
sd->data_offset = 0; sd->data_offset = 0;