mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

block: Fix block-set-write-threshold not to use funky error class

Browse Source 
Error classes are a leftover from the days of "rich" error objects.
New code should always use ERROR_CLASS_GENERIC_ERROR.  Commit e246211
added a use of ERROR_CLASS_DEVICE_NOT_FOUND.  Replace it.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
Markus Armbruster 2015-03-13 18:51:38 +01:00 committed by Kevin Wolf
parent a1f688f415
commit 6ec46ad541
2 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
block/write-threshold.c
View File

@ -112,7 +112,7 @@ void qmp_block_set_write_threshold(const char *node_name,
bs = bdrv_find_node(node_name); bs = bdrv_find_node(node_name);
if (!bs) { if (!bs) {
error_set(errp, QERR_DEVICE_NOT_FOUND, node_name); error_setg(errp, "Device '%s' not found", node_name);
return; return;
} }

4
qapi/block-core.json
View File

@ -1961,10 +1961,6 @@
# @write-threshold: configured threshold for the block device, bytes. # @write-threshold: configured threshold for the block device, bytes.
# Use 0 to disable the threshold. # Use 0 to disable the threshold.
# #
# Returns: Nothing on success
# If @node name is not found on the block device graph,
# DeviceNotFound
#
# Since: 2.3 # Since: 2.3
## ##
{ 'command': 'block-set-write-threshold', { 'command': 'block-set-write-threshold',