mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ui: remove 'sync' parameter from vnc_update_client

Browse Source 
There is only one caller of vnc_update_client and that always passes false
for the 'sync' parameter.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-id: 20171218191228.31018-2-berrange@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
This commit is contained in:
Daniel P. Berrange 2017-12-18 19:12:16 +00:00 committed by Gerd Hoffmann
parent 090fdc83b0
commit 6af998db05
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
ui/vnc.c
View File

@ -596,7 +596,7 @@ VncInfo2List *qmp_query_vnc_servers(Error **errp)
3) resolutions > 1024 3) resolutions > 1024
*/ */
static int vnc_update_client(VncState *vs, int has_dirty, bool sync); static int vnc_update_client(VncState *vs, int has_dirty);
static void vnc_disconnect_start(VncState *vs); static void vnc_disconnect_start(VncState *vs);
static void vnc_colordepth(VncState *vs); static void vnc_colordepth(VncState *vs);
@ -961,7 +961,7 @@ static int find_and_clear_dirty_height(VncState *vs,
return h; return h;
} }
static int vnc_update_client(VncState *vs, int has_dirty, bool sync) static int vnc_update_client(VncState *vs, int has_dirty)
{ {
if (vs->disconnecting) { if (vs->disconnecting) {
vnc_disconnect_finish(vs); vnc_disconnect_finish(vs);
@ -1025,9 +1025,6 @@ static int vnc_update_client(VncState *vs, int has_dirty, bool sync)
} }
vnc_job_push(job); vnc_job_push(job);
if (sync) {
vnc_jobs_join(vs);
}
vs->force_update = 0; vs->force_update = 0;
vs->has_dirty = 0; vs->has_dirty = 0;
return n; return n;
@ -1035,8 +1032,6 @@ static int vnc_update_client(VncState *vs, int has_dirty, bool sync)
if (vs->disconnecting) { if (vs->disconnecting) {
vnc_disconnect_finish(vs); vnc_disconnect_finish(vs);
} else if (sync) {
vnc_jobs_join(vs);
} }
return 0; return 0;
@ -2863,7 +2858,7 @@ static void vnc_refresh(DisplayChangeListener *dcl)
vnc_unlock_display(vd); vnc_unlock_display(vd);
QTAILQ_FOREACH_SAFE(vs, &vd->clients, next, vn) { QTAILQ_FOREACH_SAFE(vs, &vd->clients, next, vn) {
rects += vnc_update_client(vs, has_dirty, false); rects += vnc_update_client(vs, has_dirty);
/* vs might be free()ed here */ /* vs might be free()ed here */
} }