mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

target/arm: Make SYS_HEAPINFO work with RAM that doesn't start at 0

Browse Source 
The semihosting SYS_HEAPINFO call is supposed to return an array
of four guest addresses:
 * base of heap memory
 * limit of heap memory
 * base of stack memory
 * limit of stack memory

Some semihosting programs (including those compiled to use the
'newlib' embedded C library) use this call to work out where they
should initialize themselves to.

QEMU's implementation when in system emulation mode is very
simplistic: we say that the heap starts halfway into RAM and
continues to the end of RAM, and the stack starts at the top of RAM
and works down to the bottom.  Unfortunately the code assumes that
the base address of RAM is at address 0, so on boards like 'virt'
where this is not true the addresses returned will all be wrong and
the guest application will usually crash.

Conveniently since all Arm boards call arm_load_kernel() we have the
base address of the main RAM block in the arm_boot_info struct which
is accessible via the CPU object.  Use this to return sensible values
from SYS_HEAPINFO.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Message-id: 20201119092346.32356-1-peter.maydell@linaro.org
This commit is contained in:
Peter Maydell 2020-11-19 09:23:46 +00:00
parent 75bf6e17f9
commit 6951595183
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
target/arm/arm-semi.c
View File

@ -36,6 +36,7 @@
#else #else
#include "exec/gdbstub.h" #include "exec/gdbstub.h"
#include "qemu/cutils.h" #include "qemu/cutils.h"
#include "hw/arm/boot.h"
#endif #endif
#define TARGET_SYS_OPEN 0x01 #define TARGET_SYS_OPEN 0x01
@ -1014,6 +1015,9 @@ target_ulong do_arm_semihosting(CPUARMState *env)
int i; int i;
#ifdef CONFIG_USER_ONLY #ifdef CONFIG_USER_ONLY
TaskState *ts = cs->opaque; TaskState *ts = cs->opaque;
#else
const struct arm_boot_info *info = env->boot_info;
target_ulong rambase = info->loader_start;
#endif #endif
GET_ARG(0); GET_ARG(0);
@ -1046,10 +1050,10 @@ target_ulong do_arm_semihosting(CPUARMState *env)
#else #else
limit = ram_size; limit = ram_size;
/* TODO: Make this use the limit of the loaded application. */ /* TODO: Make this use the limit of the loaded application. */
retvals[0] = limit / 2; retvals[0] = rambase + limit / 2;
retvals[1] = limit; retvals[1] = rambase + limit;
retvals[2] = limit; /* Stack base */ retvals[2] = rambase + limit; /* Stack base */
retvals[3] = 0; /* Stack limit. */ retvals[3] = rambase; /* Stack limit. */
#endif #endif
for (i = 0; i < ARRAY_SIZE(retvals); i++) { for (i = 0; i < ARRAY_SIZE(retvals); i++) {