mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

monitor: fail when 'i' type is greater than 32-bit

Browse Source 
The 'i' argument type is for 32-bit only and most handlers
will use an 'int' to store its value.

It's better to fail gracefully when the user enters a value
greater than 32-bit than to get subtle casting bugs.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
This commit is contained in:
Luiz Capitulino 2009-08-28 15:27:26 -03:00 committed by Anthony Liguori
parent 53773581b8
commit 675ebef9e2
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
monitor.c
View File

@ -2759,6 +2759,12 @@ static const mon_cmd_t *monitor_parse_command(Monitor *mon,
} }
if (get_expr(mon, &val, &p)) if (get_expr(mon, &val, &p))
goto fail; goto fail;
/* Check if 'i' is greater than 32-bit */
if ((c == 'i') && ((val >> 32) & 0xffffffff)) {
monitor_printf(mon, "\'%s\' has failed: ", cmdname);
monitor_printf(mon, "integer is for 32-bit values\n");
goto fail;
}
qdict_put(qdict, key, qint_from_int(val)); qdict_put(qdict, key, qint_from_int(val));
} }
break; break;