mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

python/machine: Disable pylint warning for open() in _pre_launch

Browse Source 
Shift the open() call later so that the pylint pragma applies *only* to
that one open() call. Add a note that suggests why this is safe: the
resource is unconditionally cleaned up in _post_shutdown().

_post_shutdown is called after failed launches (see launch()), and
unconditionally after every call to shutdown(), and therefore also on
__exit__.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Message-id: 20210527211715.394144-6-jsnow@redhat.com
Message-id: 20210517184808.3562549-6-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
This commit is contained in:
John Snow 2021-05-27 17:16:49 -04:00
parent 8825fed82a
commit 63c33f3c28
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
python/qemu/machine.py
View File

@ -306,7 +306,6 @@ class QEMUMachine:
def _pre_launch(self) -> None: def _pre_launch(self) -> None:
self._qemu_log_path = os.path.join(self.temp_dir, self._name + ".log") self._qemu_log_path = os.path.join(self.temp_dir, self._name + ".log")
self._qemu_log_file = open(self._qemu_log_path, 'wb')
if self._console_set: if self._console_set:
self._remove_files.append(self._console_address) self._remove_files.append(self._console_address)
@ -321,6 +320,11 @@ class QEMUMachine:
nickname=self._name nickname=self._name
) )
# NOTE: Make sure any opened resources are *definitely* freed in
# _post_shutdown()!
# pylint: disable=consider-using-with
self._qemu_log_file = open(self._qemu_log_path, 'wb')
def _post_launch(self) -> None: def _post_launch(self) -> None:
if self._qmp_connection: if self._qmp_connection:
self._qmp.accept() self._qmp.accept()