mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

intc/xilinx_intc: Don't clear level sens. IRQs without ACK

Browse Source 
For level sensitive interrupts, ISR bits are cleared when the input pin
is lowered. This is incorrect. Only software can clear ISR bits (via
IAR or direct write to ISR with !MER(2)).

Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
This commit is contained in:
Peter Crosthwaite 2013-06-11 10:58:25 +10:00 committed by Edgar E. Iglesias
parent 37a011e9ba
commit 6327c221ff
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
hw/intc/xilinx_intc.c
View File

@ -135,13 +135,7 @@ static void irq_handler(void *opaque, int irq, int level)
return; return;
} }
/* Update source flops. Don't clear unless level triggered. p->regs[R_ISR] |= (level << irq);
Edge triggered interrupts only go away when explicitely acked to
the interrupt controller. */
if (!(p->c_kind_of_intr & (1 << irq)) || level) {
p->regs[R_ISR] &= ~(1 << irq);
p->regs[R_ISR] |= (level << irq);
}
update_irq(p); update_irq(p);
} }