mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "Change net/socket.c to use socket_*() functions"

Browse Source 
Since commit 7e8449594c, the socket connect code is blocking, because
calling socket_connect() without callback is blocking.  This reverts the
commit.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Paolo Bonzini 2016-08-30 14:04:12 +02:00
parent 135a972b45
commit 616018352c
1 changed files with 28 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
net/socket.c
View File

@ -489,30 +489,41 @@ static int net_socket_listen_init(NetClientState *peer,
{ {
NetClientState *nc; NetClientState *nc;
NetSocketState *s; NetSocketState *s;
SocketAddress *saddr; struct sockaddr_in saddr;
int ret; int fd, ret;
Error *local_error = NULL;
saddr = socket_parse(host_str, &local_error); if (parse_host_port(&saddr, host_str) < 0)
if (saddr == NULL) { return -1;
error_report_err(local_error);
fd = qemu_socket(PF_INET, SOCK_STREAM, 0);
if (fd < 0) {
perror("socket");
return -1; return -1;
} }
qemu_set_nonblock(fd);
ret = socket_listen(saddr, &local_error); socket_set_fast_reuse(fd);
ret = bind(fd, (struct sockaddr *)&saddr, sizeof(saddr));
if (ret < 0) { if (ret < 0) {
error_report_err(local_error); perror("bind");
closesocket(fd);
return -1;
}
ret = listen(fd, 0);
if (ret < 0) {
perror("listen");
closesocket(fd);
return -1; return -1;
} }
nc = qemu_new_net_client(&net_socket_info, peer, model, name); nc = qemu_new_net_client(&net_socket_info, peer, model, name);
s = DO_UPCAST(NetSocketState, nc, nc); s = DO_UPCAST(NetSocketState, nc, nc);
s->fd = -1; s->fd = -1;
s->listen_fd = ret; s->listen_fd = fd;
s->nc.link_down = true; s->nc.link_down = true;
qemu_set_fd_handler(s->listen_fd, net_socket_accept, NULL, s); qemu_set_fd_handler(s->listen_fd, net_socket_accept, NULL, s);
qapi_free_SocketAddress(saddr);
return 0; return 0;
} }
@ -523,15 +534,10 @@ static int net_socket_connect_init(NetClientState *peer,
{ {
NetSocketState *s; NetSocketState *s;
int fd, connected, ret; int fd, connected, ret;
char *addr_str; struct sockaddr_in saddr;
SocketAddress *saddr;
Error *local_error = NULL;
saddr = socket_parse(host_str, &local_error); if (parse_host_port(&saddr, host_str) < 0)
if (saddr == NULL) {
error_report_err(local_error);
return -1; return -1;
}
fd = qemu_socket(PF_INET, SOCK_STREAM, 0); fd = qemu_socket(PF_INET, SOCK_STREAM, 0);
if (fd < 0) { if (fd < 0) {
@ -539,9 +545,10 @@ static int net_socket_connect_init(NetClientState *peer,
return -1; return -1;
} }
qemu_set_nonblock(fd); qemu_set_nonblock(fd);
connected = 0; connected = 0;
for(;;) { for(;;) {
ret = socket_connect(saddr, &local_error, NULL, NULL); ret = connect(fd, (struct sockaddr *)&saddr, sizeof(saddr));
if (ret < 0) { if (ret < 0) {
if (errno == EINTR || errno == EWOULDBLOCK) { if (errno == EINTR || errno == EWOULDBLOCK) {
/* continue */ /* continue */
@ -550,7 +557,7 @@ static int net_socket_connect_init(NetClientState *peer,
errno == EINVAL) { errno == EINVAL) {
break; break;
} else { } else {
error_report_err(local_error); perror("connect");
closesocket(fd); closesocket(fd);
return -1; return -1;
} }
@ -562,15 +569,9 @@ static int net_socket_connect_init(NetClientState *peer,
s = net_socket_fd_init(peer, model, name, fd, connected); s = net_socket_fd_init(peer, model, name, fd, connected);
if (!s) if (!s)
return -1; return -1;
addr_str = socket_address_to_string(saddr, &local_error);
if (addr_str == NULL)
return -1;
snprintf(s->nc.info_str, sizeof(s->nc.info_str), snprintf(s->nc.info_str, sizeof(s->nc.info_str),
"socket: connect to %s", addr_str); "socket: connect to %s:%d",
qapi_free_SocketAddress(saddr); inet_ntoa(saddr.sin_addr), ntohs(saddr.sin_port));
g_free(addr_str);
return 0; return 0;
} }