mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

configure: Check mkdir result directly, not via $?

Browse Source 
Shellcheck warns that we have one place where we run a command and
then check if it failed using $?; this is better written to simply
check the command in the 'if' statement directly.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20220825150703.4074125-7-peter.maydell@linaro.org
This commit is contained in:
Peter Maydell 2022-08-25 16:07:02 +01:00
parent cc3c71e89f
commit 563661c056
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
configure vendored
View File

@ -67,8 +67,7 @@ fi
# it when configure exits.) # it when configure exits.)
TMPDIR1="config-temp" TMPDIR1="config-temp"
rm -rf "${TMPDIR1}" rm -rf "${TMPDIR1}"
mkdir -p "${TMPDIR1}" if ! mkdir -p "${TMPDIR1}"; then
if [ $? -ne 0 ]; then
echo "ERROR: failed to create temporary directory" echo "ERROR: failed to create temporary directory"
exit 1 exit 1
fi fi