mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

linux-user: Move if-elses to a switch statement.

Browse Source 
This makes adding more message types cleaner.

Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
This commit is contained in:
Huw Davies 2014-04-17 14:02:47 +01:00 committed by Riku Voipio
parent 8c0f0a60d4
commit 52b6549442
1 changed files with 32 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
linux-user/syscall.c
View File

@ -1242,25 +1242,40 @@ static inline abi_long host_to_target_cmsg(struct target_msghdr *target_msgh,
target_cmsg->cmsg_type = tswap32(cmsg->cmsg_type); target_cmsg->cmsg_type = tswap32(cmsg->cmsg_type);
target_cmsg->cmsg_len = tswapal(TARGET_CMSG_LEN(len)); target_cmsg->cmsg_len = tswapal(TARGET_CMSG_LEN(len));
if ((cmsg->cmsg_level == SOL_SOCKET) && switch (cmsg->cmsg_level) {
(cmsg->cmsg_type == SCM_RIGHTS)) { case SOL_SOCKET:
switch (cmsg->cmsg_type) {
case SCM_RIGHTS:
{
int *fd = (int *)data; int *fd = (int *)data;
int *target_fd = (int *)target_data; int *target_fd = (int *)target_data;
int i, numfds = len / sizeof(int); int i, numfds = len / sizeof(int);
for (i = 0; i < numfds; i++) for (i = 0; i < numfds; i++)
target_fd[i] = tswap32(fd[i]); target_fd[i] = tswap32(fd[i]);
} else if ((cmsg->cmsg_level == SOL_SOCKET) && break;
(cmsg->cmsg_type == SO_TIMESTAMP) && }
(len == sizeof(struct timeval))) { case SO_TIMESTAMP:
/* copy struct timeval to target */ {
struct timeval *tv = (struct timeval *)data; struct timeval *tv = (struct timeval *)data;
struct target_timeval *target_tv = struct target_timeval *target_tv =
(struct target_timeval *)target_data; (struct target_timeval *)target_data;
if (len != sizeof(struct timeval))
goto unimplemented;
/* copy struct timeval to target */
target_tv->tv_sec = tswapal(tv->tv_sec); target_tv->tv_sec = tswapal(tv->tv_sec);
target_tv->tv_usec = tswapal(tv->tv_usec); target_tv->tv_usec = tswapal(tv->tv_usec);
} else { break;
}
default:
goto unimplemented;
}
break;
default:
unimplemented:
gemu_log("Unsupported ancillary data: %d/%d\n", gemu_log("Unsupported ancillary data: %d/%d\n",
cmsg->cmsg_level, cmsg->cmsg_type); cmsg->cmsg_level, cmsg->cmsg_type);
memcpy(target_data, data, len); memcpy(target_data, data, len);