mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "qdev: Add help for device properties"

Browse Source 
This reverts commit 2ba6edf0dd.

The commit has two issues:

* When it runs from the monitor, e.g. "device_add e1000,?", it prints
  to stderr instead of the monitor.

* Help looks to callers just like failed device creation.  This makes
  main() exit unsuccessfully on "-device e1000,?".

We need to do this differently.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
This commit is contained in:
Markus Armbruster 2010-01-29 19:48:59 +01:00 committed by Anthony Liguori
parent eecbb9fe6f
commit 5137b6accd
1 changed files with 2 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
hw/qdev-properties.c
View File

@ -544,19 +544,8 @@ int qdev_prop_parse(DeviceState *dev, const char *name, const char *value)
prop = qdev_prop_find(dev, name);
if (!prop) {
if (strcmp(name, "?") != 0) {
fprintf(stderr, "property \"%s.%s\" not found\n",
dev->info->name, name);
} else {
fprintf(stderr, "supported properties:\n");
if (dev->info->props != NULL) {
Property *props = dev->info->props;
while (props->name) {
fprintf(stderr, "%s.%s\n", dev->info->name, props->name);
props++;
}
}
}
fprintf(stderr, "property \"%s.%s\" not found\n",
dev->info->name, name);
return -1;
}
if (!prop->info->parse) {