mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vhost-user-gpu: Release memory returned by vu_queue_pop() with free()

Browse Source 
vu_queue_pop() returns memory that must be freed with free().

Cc: qemu-stable@nongnu.org
Reported-by: Coverity (CID 1421887 ALLOC_FREE_MISMATCH)
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
This commit is contained in:
Philippe Mathieu-Daudé 2020-03-23 12:29:41 +01:00 committed by Peter Maydell
parent 6329df5b53
commit 4ff97121a3
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
contrib/vhost-user-gpu/vhost-user-gpu.c
View File

@ -848,7 +848,7 @@ vg_handle_ctrl(VuDev *dev, int qidx)
QTAILQ_INSERT_TAIL(&vg->fenceq, cmd, next); QTAILQ_INSERT_TAIL(&vg->fenceq, cmd, next);
vg->inflight++; vg->inflight++;
} else { } else {
g_free(cmd); free(cmd);
} }
} }
} }
@ -939,7 +939,7 @@ vg_handle_cursor(VuDev *dev, int qidx)
} }
vu_queue_push(dev, vq, elem, 0); vu_queue_push(dev, vq, elem, 0);
vu_queue_notify(dev, vq); vu_queue_notify(dev, vq);
g_free(elem); free(elem);
} }
} }

2
contrib/vhost-user-gpu/virgl.c
View File

@ -519,7 +519,7 @@ virgl_write_fence(void *opaque, uint32_t fence)
g_debug("FENCE %" PRIu64, cmd->cmd_hdr.fence_id); g_debug("FENCE %" PRIu64, cmd->cmd_hdr.fence_id);
vg_ctrl_response_nodata(g, cmd, VIRTIO_GPU_RESP_OK_NODATA); vg_ctrl_response_nodata(g, cmd, VIRTIO_GPU_RESP_OK_NODATA);
QTAILQ_REMOVE(&g->fenceq, cmd, next); QTAILQ_REMOVE(&g->fenceq, cmd, next);
g_free(cmd); free(cmd);
g->inflight--; g->inflight--;
} }
} }