mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

qemu-option: qemu_opts_from_qdict(): use error_set()

Browse Source 
do_device_add() and do_netdev_add() call qerror_report_err() to maintain
their QError semantics.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Reviewed-By: Laszlo Ersek <lersek@redhat.com>
This commit is contained in:
Luiz Capitulino 2012-04-18 17:24:01 -03:00
parent 384f2139ff
commit 4e89978e20
4 changed files with 35 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
hw/qdev-monitor.c
View File

@ -554,10 +554,13 @@ void do_info_qdm(Monitor *mon)
int do_device_add(Monitor *mon, const QDict *qdict, QObject **ret_data) int do_device_add(Monitor *mon, const QDict *qdict, QObject **ret_data)
{ {
Error *local_err = NULL;
QemuOpts *opts; QemuOpts *opts;
opts = qemu_opts_from_qdict(qemu_find_opts("device"), qdict); opts = qemu_opts_from_qdict(qemu_find_opts("device"), qdict, &local_err);
if (!opts) { if (error_is_set(&local_err)) {
qerror_report_err(local_err);
error_free(local_err);
return -1; return -1;
} }
if (!monitor_cur_is_qmp() && qdev_device_help(opts)) { if (!monitor_cur_is_qmp() && qdev_device_help(opts)) {

5
net.c
View File

@ -1237,11 +1237,14 @@ void net_host_device_remove(Monitor *mon, const QDict *qdict)
int do_netdev_add(Monitor *mon, const QDict *qdict, QObject **ret_data) int do_netdev_add(Monitor *mon, const QDict *qdict, QObject **ret_data)
{ {
Error *local_err = NULL;
QemuOpts *opts; QemuOpts *opts;
int res; int res;
opts = qemu_opts_from_qdict(qemu_find_opts("netdev"), qdict); opts = qemu_opts_from_qdict(qemu_find_opts("netdev"), qdict, &local_err);
if (!opts) { if (!opts) {
qerror_report_err(local_err);
error_free(local_err);
return -1; return -1;
} }

31
qemu-option.c
View File

@ -968,13 +968,19 @@ void qemu_opts_set_defaults(QemuOptsList *list, const char *params,
assert(opts); assert(opts);
} }
typedef struct OptsFromQDictState {
QemuOpts *opts;
Error **errp;
} OptsFromQDictState;
static void qemu_opts_from_qdict_1(const char *key, QObject *obj, void *opaque) static void qemu_opts_from_qdict_1(const char *key, QObject *obj, void *opaque)
{ {
OptsFromQDictState *state = opaque;
char buf[32]; char buf[32];
const char *value; const char *value;
int n; int n;
if (!strcmp(key, "id")) { if (!strcmp(key, "id") || error_is_set(state->errp)) {
return; return;
} }
@ -1002,7 +1008,8 @@ static void qemu_opts_from_qdict_1(const char *key, QObject *obj, void *opaque)
default: default:
return; return;
} }
qemu_opt_set(opaque, key, value);
qemu_opt_set_err(state->opts, key, value, state->errp);
} }
/* /*
@ -1011,21 +1018,31 @@ static void qemu_opts_from_qdict_1(const char *key, QObject *obj, void *opaque)
* Only QStrings, QInts, QFloats and QBools are copied. Entries with * Only QStrings, QInts, QFloats and QBools are copied. Entries with
* other types are silently ignored. * other types are silently ignored.
*/ */
QemuOpts *qemu_opts_from_qdict(QemuOptsList *list, const QDict *qdict) QemuOpts *qemu_opts_from_qdict(QemuOptsList *list, const QDict *qdict,
Error **errp)
{ {
QemuOpts *opts; OptsFromQDictState state;
Error *local_err = NULL; Error *local_err = NULL;
QemuOpts *opts;
opts = qemu_opts_create(list, qdict_get_try_str(qdict, "id"), 1, opts = qemu_opts_create(list, qdict_get_try_str(qdict, "id"), 1,
&local_err); &local_err);
if (error_is_set(&local_err)) { if (error_is_set(&local_err)) {
qerror_report_err(local_err); error_propagate(errp, local_err);
error_free(local_err);
return NULL; return NULL;
} }
assert(opts != NULL); assert(opts != NULL);
qdict_iter(qdict, qemu_opts_from_qdict_1, opts);
state.errp = &local_err;
state.opts = opts;
qdict_iter(qdict, qemu_opts_from_qdict_1, &state);
if (error_is_set(&local_err)) {
error_propagate(errp, local_err);
qemu_opts_del(opts);
return NULL;
}
return opts; return opts;
} }

3
qemu-option.h
View File

@ -132,7 +132,8 @@ int qemu_opts_do_parse(QemuOpts *opts, const char *params, const char *firstname
QemuOpts *qemu_opts_parse(QemuOptsList *list, const char *params, int permit_abbrev); QemuOpts *qemu_opts_parse(QemuOptsList *list, const char *params, int permit_abbrev);
void qemu_opts_set_defaults(QemuOptsList *list, const char *params, void qemu_opts_set_defaults(QemuOptsList *list, const char *params,
int permit_abbrev); int permit_abbrev);
QemuOpts *qemu_opts_from_qdict(QemuOptsList *list, const QDict *qdict); QemuOpts *qemu_opts_from_qdict(QemuOptsList *list, const QDict *qdict,
Error **errp);
QDict *qemu_opts_to_qdict(QemuOpts *opts, QDict *qdict); QDict *qemu_opts_to_qdict(QemuOpts *opts, QDict *qdict);
typedef int (*qemu_opts_loopfunc)(QemuOpts *opts, void *opaque); typedef int (*qemu_opts_loopfunc)(QemuOpts *opts, void *opaque);