mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

spapr_iommu: drop erroneous check in h_put_tce_indirect()

Browse Source 
The tce_list variable is not a TCE but the address to a TCE: we shouldn't
clear permission bits as we do now. And this is dead code anyway since we
check tce_list is 4K aligned a few lines above.

This patch doesn't fix any bug, it is only code cleanup.

Suggested-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Alexander Graf <agraf@suse.de>
This commit is contained in:
Greg Kurz 2015-07-02 16:23:11 +10:00 committed by Alexander Graf
parent 9b7d9284c3
commit 4d9ab7d4ed
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hw/ppc/spapr_iommu.c
View File

@ -267,9 +267,7 @@ static target_ulong h_put_tce_indirect(PowerPCCPU *cpu,
ioba &= page_mask; ioba &= page_mask;
for (i = 0; i < npages; ++i, ioba += page_size) { for (i = 0; i < npages; ++i, ioba += page_size) {
target_ulong off = (tce_list & ~SPAPR_TCE_RW) + tce = ldq_be_phys(cs->as, tce_list + i * sizeof(target_ulong));
i * sizeof(target_ulong);
tce = ldq_be_phys(cs->as, off);
ret = put_tce_emu(tcet, ioba, tce); ret = put_tce_emu(tcet, ioba, tce);
if (ret) { if (ret) {