mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hw/net/e1000e: Remove overwritten read handler for STATUS register

Browse Source 
The STATUS register readop handler is initialized first with
the generic e1000e_mac_readreg() handler:

  2861 #define e1000e_getreg(x)    [x] = e1000e_mac_readreg
  2862 typedef uint32_t (*readops)(E1000ECore *, int);
  2863 static const readops e1000e_macreg_readops[] = {
  ....
  2919     e1000e_getreg(STATUS),

Then overwritten with the specific e1000e_get_status handler:

  3018     [STATUS]  = e1000e_get_status,

To avoid confusion, remove the overwritten initialization.

6f3fbe4ed0 ("net: Introduce e1000e device emulation")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Message-Id: <20200904131402.590055-2-f4bug@amsat.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
This commit is contained in:
Philippe Mathieu-Daudé 2020-09-04 15:14:01 +02:00 committed by Laurent Vivier
parent c857f9050c
commit 4a4a604cc6
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
hw/net/e1000e_core.c
View File

@ -2916,7 +2916,6 @@ static const readops e1000e_macreg_readops[] = {
e1000e_getreg(TSYNCRXCTL), e1000e_getreg(TSYNCRXCTL),
e1000e_getreg(TDH), e1000e_getreg(TDH),
e1000e_getreg(LEDCTL), e1000e_getreg(LEDCTL),
e1000e_getreg(STATUS),
e1000e_getreg(TCTL), e1000e_getreg(TCTL),
e1000e_getreg(TDBAL), e1000e_getreg(TDBAL),
e1000e_getreg(TDLEN), e1000e_getreg(TDLEN),