mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hw/intc/sh_intc: Remove excessive parenthesis

Browse Source 
Drop unneded parenthesis and split up one complex expression to write
it with less brackets so it's easier to follow.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <a48e849e5b803a952ed15a2502cfece2bde68934.1635541329.git.balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
This commit is contained in:
BALATON Zoltan 2021-10-29 23:02:09 +02:00 committed by Philippe Mathieu-Daudé
parent 51cb902bac
commit 46ea1f8236
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
hw/intc/sh_intc.c
View File

@ -23,7 +23,7 @@ void sh_intc_toggle_source(struct intc_source *source,
int pending_changed = 0; int pending_changed = 0;
int old_pending; int old_pending;
if ((source->enable_count == source->enable_max) && (enable_adj == -1)) { if (source->enable_count == source->enable_max && enable_adj == -1) {
enable_changed = -1; enable_changed = -1;
} }
source->enable_count += enable_adj; source->enable_count += enable_adj;
@ -68,7 +68,7 @@ void sh_intc_toggle_source(struct intc_source *source,
static void sh_intc_set_irq(void *opaque, int n, int level) static void sh_intc_set_irq(void *opaque, int n, int level)
{ {
struct intc_desc *desc = opaque; struct intc_desc *desc = opaque;
struct intc_source *source = &(desc->sources[n]); struct intc_source *source = &desc->sources[n];
if (level && !source->asserted) { if (level && !source->asserted) {
sh_intc_toggle_source(source, 0, 1); sh_intc_toggle_source(source, 0, 1);
@ -163,7 +163,7 @@ static void sh_intc_locate(struct intc_desc *desc,
*modep = mode | INTC_MODE_IS_PRIO; *modep = mode | INTC_MODE_IS_PRIO;
*datap = &pr->value; *datap = &pr->value;
*enums = pr->enum_ids; *enums = pr->enum_ids;
*first = (pr->reg_width / pr->field_width) - 1; *first = pr->reg_width / pr->field_width - 1;
*width = pr->field_width; *width = pr->field_width;
return; return;
} }
@ -244,7 +244,8 @@ static void sh_intc_write(void *opaque, hwaddr offset,
} }
for (k = 0; k <= first; k++) { for (k = 0; k <= first; k++) {
mask = ((1 << width) - 1) << ((first - k) * width); mask = (1 << width) - 1;
mask <<= (first - k) * width;
if ((*valuep & mask) == (value & mask)) { if ((*valuep & mask) == (value & mask)) {
continue; continue;