From 3f8f1313e01984a892ddbdb91c94cd0aa6a5660f Mon Sep 17 00:00:00 2001 From: Gerd Hoffmann Date: Wed, 14 Jun 2017 10:45:38 +0200 Subject: [PATCH] console: remove do_safe_dpy_refresh MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Drop the temporary workaround for the broken display updates. All display adapters are updated, so this should be safe without causing regressions. Signed-off-by: Gerd Hoffmann Acked-by: Alex Bennée Message-id: 20170614084538.32480-1-kraxel@redhat.com --- ui/console.c | 25 +------------------------ 1 file changed, 1 insertion(+), 24 deletions(-) diff --git a/ui/console.c b/ui/console.c index d914cced53..af0c56c600 100644 --- a/ui/console.c +++ b/ui/console.c @@ -1579,36 +1579,13 @@ bool dpy_gfx_check_format(QemuConsole *con, return true; } -/* - * Safe DPY refresh for TCG guests. We use the exclusive mechanism to - * ensure the TCG vCPUs are quiescent so we can avoid races between - * dirty page tracking for direct frame-buffer access by the guest. - * - * This is a temporary stopgap until we've fixed the dirty tracking - * races in display adapters. - */ -static void do_safe_dpy_refresh(DisplayChangeListener *dcl) -{ - qemu_mutex_unlock_iothread(); - start_exclusive(); - qemu_mutex_lock_iothread(); - dcl->ops->dpy_refresh(dcl); - qemu_mutex_unlock_iothread(); - end_exclusive(); - qemu_mutex_lock_iothread(); -} - static void dpy_refresh(DisplayState *s) { DisplayChangeListener *dcl; QLIST_FOREACH(dcl, &s->listeners, next) { if (dcl->ops->dpy_refresh) { - if (tcg_enabled()) { - do_safe_dpy_refresh(dcl); - } else { - dcl->ops->dpy_refresh(dcl); - } + dcl->ops->dpy_refresh(dcl); } } }