virtio-crypto: fix NULL pointer dereference in virtio_crypto_free_request
Ensure op_info is not NULL in case of QCRYPTODEV_BACKEND_ALG_SYM algtype.
Fixes: 0e660a6f90
("crypto: Introduce RSA algorithm")
Signed-off-by: Mauro Matteo Cascella <mcascell@redhat.com>
Reported-by: Yiming Tao <taoym@zju.edu.cn>
Message-Id: <20230509075317.1132301-1-mcascell@redhat.com>
Reviewed-by: Gonglei <arei.gonglei@huawei.com>
Reviewed-by: zhenwei pi<pizhenwei@bytedance.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This commit is contained in:
parent
1fac00f70b
commit
3e69908907
@ -476,6 +476,7 @@ static void virtio_crypto_free_request(VirtIOCryptoReq *req)
|
|||||||
size_t max_len;
|
size_t max_len;
|
||||||
CryptoDevBackendSymOpInfo *op_info = req->op_info.u.sym_op_info;
|
CryptoDevBackendSymOpInfo *op_info = req->op_info.u.sym_op_info;
|
||||||
|
|
||||||
|
if (op_info) {
|
||||||
max_len = op_info->iv_len +
|
max_len = op_info->iv_len +
|
||||||
op_info->aad_len +
|
op_info->aad_len +
|
||||||
op_info->src_len +
|
op_info->src_len +
|
||||||
@ -485,6 +486,7 @@ static void virtio_crypto_free_request(VirtIOCryptoReq *req)
|
|||||||
/* Zeroize and free request data structure */
|
/* Zeroize and free request data structure */
|
||||||
memset(op_info, 0, sizeof(*op_info) + max_len);
|
memset(op_info, 0, sizeof(*op_info) + max_len);
|
||||||
g_free(op_info);
|
g_free(op_info);
|
||||||
|
}
|
||||||
} else if (req->flags == QCRYPTODEV_BACKEND_ALG_ASYM) {
|
} else if (req->flags == QCRYPTODEV_BACKEND_ALG_ASYM) {
|
||||||
CryptoDevBackendAsymOpInfo *op_info = req->op_info.u.asym_op_info;
|
CryptoDevBackendAsymOpInfo *op_info = req->op_info.u.asym_op_info;
|
||||||
if (op_info) {
|
if (op_info) {
|
||||||
|
Loading…
Reference in New Issue
Block a user