mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hw: misc: edu: rename local vars in edu_check_range

Browse Source 
This serves to make the local variables a bit less ambiguous.

The latter two arguments are named to match DMA_START, and
DMA_SIZE.

Signed-off-by: Chris Friedt <cfriedt@meta.com>
Message-ID: <20221018122551.94567-2-cfriedt@meta.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
This commit is contained in:
Chris Friedt 2022-10-18 08:25:50 -04:00 committed by Thomas Huth
parent 6982674159
commit 3e64d7d7b8
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
hw/misc/edu.c
View File

@ -103,24 +103,24 @@ static void edu_lower_irq(EduState *edu, uint32_t val)
}
}
static void edu_check_range(uint64_t addr, uint64_t size1,
uint64_t start, uint64_t size2)
static void edu_check_range(uint64_t xfer_start, uint64_t xfer_size,
uint64_t dma_start, uint64_t dma_size)
{
uint64_t end1 = addr + size1;
uint64_t end2 = start + size2;
uint64_t xfer_end = xfer_start + xfer_size;
uint64_t dma_end = dma_start + dma_size;
/*
* 1. ensure we aren't overflowing
* 2. ensure that [addr, end1) is within [start, size2)
* 2. ensure that xfer is within dma address range
*/
if (end2 >= start && end1 >= addr &&
addr >= start && end1 <= end2) {
if (dma_end >= dma_start && xfer_end >= xfer_start &&
xfer_start >= dma_start && xfer_end <= dma_end) {
return;
}
hw_error("EDU: DMA range 0x%016"PRIx64"-0x%016"PRIx64
" out of bounds (0x%016"PRIx64"-0x%016"PRIx64")!",
addr, end1 - 1, start, end2 - 1);
xfer_start, xfer_end - 1, dma_start, dma_end - 1);
}
static dma_addr_t edu_clamp_addr(const EduState *edu, dma_addr_t addr)