mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vhost-user: pass message as a pointer to process_message_reply()

Browse Source 
process_message_reply() was recently updated to get full message
content instead of only its request field.

There is no need to copy all the struct content into the stack,
so just pass its pointer as const.

Reviewed-by: Jens Freimann <jfreiman@redhat.com>
Reviewed-by: Zhiyong Yang <zhiyong.yang@intel.com>
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
This commit is contained in:
Maxime Coquelin 2017-05-24 11:05:20 +02:00 committed by Michael S. Tsirkin
parent 75ebec11af
commit 3cf7daf8c3
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
hw/virtio/vhost-user.c
View File

@ -162,11 +162,11 @@ fail:
}
static int process_message_reply(struct vhost_dev *dev,
VhostUserMsg msg)
const VhostUserMsg *msg)
{
VhostUserMsg msg_reply;
if ((msg.flags & VHOST_USER_NEED_REPLY_MASK) == 0) {
if ((msg->flags & VHOST_USER_NEED_REPLY_MASK) == 0) {
return 0;
}
@ -174,10 +174,10 @@ static int process_message_reply(struct vhost_dev *dev,
return -1;
}
if (msg_reply.request != msg.request) {
if (msg_reply.request != msg->request) {
error_report("Received unexpected msg type."
"Expected %d received %d",
msg.request, msg_reply.request);
msg->request, msg_reply.request);
return -1;
}
@ -324,7 +324,7 @@ static int vhost_user_set_mem_table(struct vhost_dev *dev,
}
if (reply_supported) {
return process_message_reply(dev, msg);
return process_message_reply(dev, &msg);
}
return 0;
@ -716,7 +716,7 @@ static int vhost_user_net_set_mtu(struct vhost_dev *dev, uint16_t mtu)
/* If reply_ack supported, slave has to ack specified MTU is valid */
if (reply_supported) {
return process_message_reply(dev, msg);
return process_message_reply(dev, &msg);
}
return 0;