mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

target/hexagon/idef-parser: Use gen_constant for gen_extend_tcg_width_op

Browse Source 
We already have a temporary, res, which we can use for the intermediate
shift result.  Simplify the constant to -1 instead of 0xf*f.
This was the last use of gen_tmp_value, so remove it.

Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
This commit is contained in:
Richard Henderson 2023-02-26 17:12:05 -10:00
parent e0df97777c
commit 3b10fd8f09
1 changed files with 3 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
target/hexagon/idef-parser/parser-helpers.c
View File

@ -305,26 +305,6 @@ HexValue gen_tmp(Context *c,
return rvalue; return rvalue;
} }
static HexValue gen_tmp_value(Context *c,
YYLTYPE *locp,
const char *value,
unsigned bit_width,
HexSignedness signedness)
{
HexValue rvalue;
assert(bit_width == 32 || bit_width == 64);
memset(&rvalue, 0, sizeof(HexValue));
rvalue.type = TEMP;
rvalue.bit_width = bit_width;
rvalue.signedness = signedness;
rvalue.is_dotnew = false;
rvalue.tmp.index = c->inst.tmp_count;
OUT(c, locp, "TCGv_i", &bit_width, " tmp_", &c->inst.tmp_count,
" = tcg_const_i", &bit_width, "(", value, ");\n");
c->inst.tmp_count++;
return rvalue;
}
static HexValue gen_constant_from_imm(Context *c, static HexValue gen_constant_from_imm(Context *c,
YYLTYPE *locp, YYLTYPE *locp,
HexValue *value) HexValue *value)
@ -1120,15 +1100,11 @@ static HexValue gen_extend_tcg_width_op(Context *c,
OUT(c, locp, "tcg_gen_subfi_i", &dst_width); OUT(c, locp, "tcg_gen_subfi_i", &dst_width);
OUT(c, locp, "(", &shift, ", ", &dst_width, ", ", &src_width_m, ");\n"); OUT(c, locp, "(", &shift, ", ", &dst_width, ", ", &src_width_m, ");\n");
if (signedness == UNSIGNED) { if (signedness == UNSIGNED) {
const char *mask_str = (dst_width == 32) HexValue mask = gen_constant(c, locp, "-1", dst_width, UNSIGNED);
? "0xffffffff"
: "0xffffffffffffffff";
HexValue mask = gen_tmp_value(c, locp, mask_str,
dst_width, UNSIGNED);
OUT(c, locp, "tcg_gen_shr_i", &dst_width, "(", OUT(c, locp, "tcg_gen_shr_i", &dst_width, "(",
&mask, ", ", &mask, ", ", &shift, ");\n"); &res, ", ", &mask, ", ", &shift, ");\n");
OUT(c, locp, "tcg_gen_and_i", &dst_width, "(", OUT(c, locp, "tcg_gen_and_i", &dst_width, "(",
&res, ", ", value, ", ", &mask, ");\n"); &res, ", ", &res, ", ", value, ");\n");
} else { } else {
OUT(c, locp, "tcg_gen_shl_i", &dst_width, "(", OUT(c, locp, "tcg_gen_shl_i", &dst_width, "(",
&res, ", ", value, ", ", &shift, ");\n"); &res, ", ", value, ", ", &shift, ");\n");