mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tests/qtest: aspeed_smc-test: Avoid using hardcoded /tmp

Browse Source 
This case was written to use hardcoded /tmp directory for temporary
files. Update to use g_file_open_tmp() for a portable implementation.

Signed-off-by: Bin Meng <bin.meng@windriver.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Message-Id: <20220925113032.1949844-7-bmeng.cn@gmail.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
This commit is contained in:
Bin Meng 2022-09-25 19:29:44 +08:00 committed by Thomas Huth
parent d9eefd35b6
commit 39df79e4ed
1 changed files with 2 additions and 3 deletions

5
tests/qtest/aspeed_smc-test.c

@ -608,16 +608,15 @@ static void test_write_block_protect_bottom_bit(void)
flash_reset(); flash_reset();
} }
static char tmp_path[] = "/tmp/qtest.m25p80.XXXXXX";
int main(int argc, char **argv) int main(int argc, char **argv)
{ {
g_autofree char *tmp_path = NULL;
int ret; int ret;
int fd; int fd;
g_test_init(&argc, &argv, NULL); g_test_init(&argc, &argv, NULL);
fd = mkstemp(tmp_path); fd = g_file_open_tmp("qtest.m25p80.XXXXXX", &tmp_path, NULL);
g_assert(fd >= 0); g_assert(fd >= 0);
ret = ftruncate(fd, FLASH_SIZE); ret = ftruncate(fd, FLASH_SIZE);
g_assert(ret == 0); g_assert(ret == 0);