mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

s390x/tcg: MVCS/MVCP: Properly wrap the length

Browse Source 
... and don't perform any move in case the length is zero.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
This commit is contained in:
David Hildenbrand 2019-09-03 13:46:24 +02:00
parent a7627565ae
commit 373290d8a8
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
target/s390x/mem_helper.c
View File

@ -1980,10 +1980,13 @@ uint32_t HELPER(mvcs)(CPUS390XState *env, uint64_t l, uint64_t a1, uint64_t a2)
s390_program_interrupt(env, PGM_SPECIAL_OP, ILEN_AUTO, ra); s390_program_interrupt(env, PGM_SPECIAL_OP, ILEN_AUTO, ra);
} }
l = wrap_length32(env, l);
if (l > 256) { if (l > 256) {
/* max 256 */ /* max 256 */
l = 256; l = 256;
cc = 3; cc = 3;
} else if (!l) {
return cc;
} }
/* XXX replace w/ memcpy */ /* XXX replace w/ memcpy */
@ -2009,10 +2012,13 @@ uint32_t HELPER(mvcp)(CPUS390XState *env, uint64_t l, uint64_t a1, uint64_t a2)
s390_program_interrupt(env, PGM_SPECIAL_OP, ILEN_AUTO, ra); s390_program_interrupt(env, PGM_SPECIAL_OP, ILEN_AUTO, ra);
} }
l = wrap_length32(env, l);
if (l > 256) { if (l > 256) {
/* max 256 */ /* max 256 */
l = 256; l = 256;
cc = 3; cc = 3;
} else if (!l) {
return cc;
} }
/* XXX replace w/ memcpy */ /* XXX replace w/ memcpy */