mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

scsi: always call notifier on async cancellation

Browse Source 
This was found by code inspection.  If the request is cancelled twice,
the notifier is never called on the second cancellation request,
and hence for example a TMF might never finish.

All the calls in scsi_req_cancel_async are idempotent, so the change
is safe.

Reviewed-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <1450290827-30508-2-git-send-email-pbonzini@redhat.com>
This commit is contained in:
Paolo Bonzini 2015-12-16 19:33:44 +01:00
parent 8aad35f678
commit 36896bffd1
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hw/scsi/scsi-bus.c
View File

@ -1759,9 +1759,6 @@ void scsi_req_cancel_async(SCSIRequest *req, Notifier *notifier)
if (notifier) { if (notifier) {
notifier_list_add(&req->cancel_notifiers, notifier); notifier_list_add(&req->cancel_notifiers, notifier);
} }
if (req->io_canceled) {
return;
}
scsi_req_ref(req); scsi_req_ref(req);
scsi_req_dequeue(req); scsi_req_dequeue(req);
req->io_canceled = true; req->io_canceled = true;