mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

apic: kvm-apic: Fix crash due to access to freed memory region

Browse Source 
kvm-apic.io_memory memory region had its parent set to NULL at
memory_region_init_io() time, so it ended up as a child in
 /unattached contaner.
As result when kvm-apic instance was deleted, the child property
 /unattached/kvm-apic-msi[XXX] contained a reference to
kvm-apic.io_memory address which was freed as part of kvm-apic.

Do the same as 'apic' and make kvm-apic instance the owner
of the memory region so that it won't end up in /unattached
and gets cleanly released along with related kvm-apic instance.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
This commit is contained in:
Igor Mammedov 2016-07-14 16:58:02 +02:00 committed by Eduardo Habkost
parent 1dfe3282cf
commit 365aa1131f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hw/i386/kvm/apic.c
View File

@ -184,8 +184,8 @@ static void kvm_apic_realize(DeviceState *dev, Error **errp)
{ {
APICCommonState *s = APIC_COMMON(dev); APICCommonState *s = APIC_COMMON(dev);
memory_region_init_io(&s->io_memory, NULL, &kvm_apic_io_ops, s, "kvm-apic-msi", memory_region_init_io(&s->io_memory, OBJECT(s), &kvm_apic_io_ops, s,
APIC_SPACE_SIZE); "kvm-apic-msi", APIC_SPACE_SIZE);
if (kvm_has_gsi_routing()) { if (kvm_has_gsi_routing()) {
msi_nonbroken = true; msi_nonbroken = true;