mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

translate-all: remove unnecessary argument to tb_invalidate_phys_range

Browse Source 
The is_cpu_write_access argument is always 0, remove it.

Reviewed-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Paolo Bonzini 2015-04-22 14:20:35 +02:00
parent 1652b97476
commit 358653391b
4 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
exec.c
View File

@ -2256,7 +2256,7 @@ static void invalidate_and_set_dirty(MemoryRegion *mr, hwaddr addr,
if (cpu_physical_memory_range_includes_clean(addr, length)) { if (cpu_physical_memory_range_includes_clean(addr, length)) {
uint8_t dirty_log_mask = memory_region_get_dirty_log_mask(mr); uint8_t dirty_log_mask = memory_region_get_dirty_log_mask(mr);
if (dirty_log_mask & (1 << DIRTY_MEMORY_CODE)) { if (dirty_log_mask & (1 << DIRTY_MEMORY_CODE)) {
tb_invalidate_phys_range(addr, addr + length, 0); tb_invalidate_phys_range(addr, addr + length);
dirty_log_mask &= ~(1 << DIRTY_MEMORY_CODE); dirty_log_mask &= ~(1 << DIRTY_MEMORY_CODE);
} }
if (dirty_log_mask) { if (dirty_log_mask) {

6
linux-user/mmap.c
View File

@ -575,7 +575,7 @@ abi_long target_mmap(abi_ulong start, abi_ulong len, int prot,
page_dump(stdout); page_dump(stdout);
printf("\n"); printf("\n");
#endif #endif
tb_invalidate_phys_range(start, start + len, 0); tb_invalidate_phys_range(start, start + len);
mmap_unlock(); mmap_unlock();
return start; return start;
fail: fail:
@ -680,7 +680,7 @@ int target_munmap(abi_ulong start, abi_ulong len)
if (ret == 0) { if (ret == 0) {
page_set_flags(start, start + len, 0); page_set_flags(start, start + len, 0);
tb_invalidate_phys_range(start, start + len, 0); tb_invalidate_phys_range(start, start + len);
} }
mmap_unlock(); mmap_unlock();
return ret; return ret;
@ -759,7 +759,7 @@ abi_long target_mremap(abi_ulong old_addr, abi_ulong old_size,
page_set_flags(old_addr, old_addr + old_size, 0); page_set_flags(old_addr, old_addr + old_size, 0);
page_set_flags(new_addr, new_addr + new_size, prot | PAGE_VALID); page_set_flags(new_addr, new_addr + new_size, prot | PAGE_VALID);
} }
tb_invalidate_phys_range(new_addr, new_addr + new_size, 0); tb_invalidate_phys_range(new_addr, new_addr + new_size);
mmap_unlock(); mmap_unlock();
return new_addr; return new_addr;
} }

5
translate-all.c
View File

@ -1042,11 +1042,10 @@ TranslationBlock *tb_gen_code(CPUState *cpu,
* access: the virtual CPU will exit the current TB if code is modified inside * access: the virtual CPU will exit the current TB if code is modified inside
* this TB. * this TB.
*/ */
void tb_invalidate_phys_range(tb_page_addr_t start, tb_page_addr_t end, void tb_invalidate_phys_range(tb_page_addr_t start, tb_page_addr_t end)
int is_cpu_write_access)
{ {
while (start < end) { while (start < end) {
tb_invalidate_phys_page_range(start, end, is_cpu_write_access); tb_invalidate_phys_page_range(start, end, 0);
start &= TARGET_PAGE_MASK; start &= TARGET_PAGE_MASK;
start += TARGET_PAGE_SIZE; start += TARGET_PAGE_SIZE;
} }

3
translate-all.h
View File

@ -23,8 +23,7 @@
void tb_invalidate_phys_page_fast(tb_page_addr_t start, int len); void tb_invalidate_phys_page_fast(tb_page_addr_t start, int len);
void tb_invalidate_phys_page_range(tb_page_addr_t start, tb_page_addr_t end, void tb_invalidate_phys_page_range(tb_page_addr_t start, tb_page_addr_t end,
int is_cpu_write_access); int is_cpu_write_access);
void tb_invalidate_phys_range(tb_page_addr_t start, tb_page_addr_t end, void tb_invalidate_phys_range(tb_page_addr_t start, tb_page_addr_t end);
int is_cpu_write_access);
void tb_check_watchpoint(CPUState *cpu); void tb_check_watchpoint(CPUState *cpu);
#ifdef CONFIG_USER_ONLY #ifdef CONFIG_USER_ONLY