mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

target/hppa: exit TB if either Data or Instruction TLB changes

Browse Source 
The current code assumes that we don't need to exit the TB
if a Data Cache Flush or Insert has happend. However, as we
have a shared Data/Instruction TLB, a Data cache flush also
flushes Instruction TLB entries, and a Data cache TLB insert
might also evict a Instruction TLB entry.

So exit the TB in all cases if Instruction translation is enabled.

Signed-off-by: Sven Schnelle <svens@stackframe.org>
Message-Id: <20190311191602.25796-11-svens@stackframe.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
This commit is contained in:
Sven Schnelle 2019-03-11 20:16:01 +01:00 committed by Richard Henderson
parent d5de20bd84
commit 32dc75698c
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
target/hppa/translate.c
View File

@ -2482,9 +2482,8 @@ static bool trans_ixtlbx(DisasContext *ctx, arg_ixtlbx *a)
gen_helper_itlbp(cpu_env, addr, reg); gen_helper_itlbp(cpu_env, addr, reg);
} }
/* Exit TB for ITLB change if mmu is enabled. This *should* not be /* Exit TB for TLB change if mmu is enabled. */
the case, since the OS TLB fill handler runs with mmu disabled. */ if (ctx->tb_flags & PSW_C) {
if (!a->data && (ctx->tb_flags & PSW_C)) {
ctx->base.is_jmp = DISAS_IAQ_N_STALE; ctx->base.is_jmp = DISAS_IAQ_N_STALE;
} }
return nullify_end(ctx); return nullify_end(ctx);
@ -2511,7 +2510,7 @@ static bool trans_pxtlbx(DisasContext *ctx, arg_pxtlbx *a)
} }
/* Exit TB for TLB change if mmu is enabled. */ /* Exit TB for TLB change if mmu is enabled. */
if (!a->data && (ctx->tb_flags & PSW_C)) { if (ctx->tb_flags & PSW_C) {
ctx->base.is_jmp = DISAS_IAQ_N_STALE; ctx->base.is_jmp = DISAS_IAQ_N_STALE;
} }
return nullify_end(ctx); return nullify_end(ctx);