mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ui/console-vc: Silence warning about sprintf() on OpenBSD

Browse Source 
The linker on OpenBSD complains:

 ld: warning: console-vc.c:824 (../src/ui/console-vc.c:824)([...]):
 warning: sprintf() is often misused, please use snprintf()

Using g_strdup_printf() is certainly better here, so let's switch
to that function instead.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
This commit is contained in:
Thomas Huth 2024-10-15 13:25:10 +02:00 committed by Michael Tokarev
parent fe71f4b0de
commit 30b1fc5a98
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ui/console-vc.c
View File

@ -648,7 +648,7 @@ static void vc_putchar(VCChardev *vc, int ch)
QemuTextConsole *s = vc->console; QemuTextConsole *s = vc->console;
int i; int i;
int x, y; int x, y;
char response[40]; g_autofree char *response = NULL;
switch(vc->state) { switch(vc->state) {
case TTY_STATE_NORM: case TTY_STATE_NORM:
@ -821,7 +821,7 @@ static void vc_putchar(VCChardev *vc, int ch)
break; break;
case 6: case 6:
/* report cursor position */ /* report cursor position */
sprintf(response, "\033[%d;%dR", response = g_strdup_printf("\033[%d;%dR",
(s->y_base + s->y) % s->total_height + 1, (s->y_base + s->y) % s->total_height + 1,
s->x + 1); s->x + 1);
vc_respond_str(vc, response); vc_respond_str(vc, response);