mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vl.c: do not allow --daemonize in combination with --preconfig CLI option

Browse Source 
some users when using --daemonize expect that QEMU will parse CLI options,
initialize VM and only then complete daemonzation by signalling lead
process to exit and start listening on monitor socket. So users treat
parent process exit as sync point to connect to QEMU's monitor.

That however doesn't work when --preconfig options is used, since it
provides monitor before completing daemonization and expects user to
issue exit-preconfig command when additional configuration via monitor
is finished. We also can't move completing daemonization before
preconfig monitor becomes available, since that would imply:
  * partially loosing ability to configure QEMU instance in --preconfig
    mode since QEMU might drop privileges, chroot and do other things
    when daemonization is completed
  * lead to loss of error messages in case they would happen after
    daemonization

Be proactive now and make options mutually exclusive, so users would
get clear error message instead of waiting for lead process exit
indefinitely before connecting to monitor.

PS:
In case someone would come up with usecase where both options should
be enabled at the same time we could drop this restriction as far
as daemonization point is left where it is now (os_setup_post).

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Message-Id: <1529501059-163139-1-git-send-email-imammedo@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
This commit is contained in:
Igor Mammedov 2018-06-20 15:24:19 +02:00 committed by Eduardo Habkost
parent 35e238c933
commit 2ee3518b53
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
vl.c
View File

@ -4134,6 +4134,12 @@ int main(int argc, char **argv, char **envp)
} }
if (is_daemonized()) { if (is_daemonized()) {
if (!preconfig_exit_requested) {
error_report("'preconfig' and 'daemonize' options are "
"mutually exclusive");
exit(EXIT_FAILURE);
}
/* According to documentation and historically, -nographic redirects /* According to documentation and historically, -nographic redirects
* serial port, parallel port and monitor to stdio, which does not work * serial port, parallel port and monitor to stdio, which does not work
* with -daemonize. We can redirect these to null instead, but since * with -daemonize. We can redirect these to null instead, but since