From 2d097a83e223d3e06de5047e95eeadf1f919ac56 Mon Sep 17 00:00:00 2001 From: Richard Henderson Date: Fri, 9 Apr 2010 21:49:00 +0200 Subject: [PATCH] tcg-hppa: Fix branch offset during retranslation. Branch offsets should only be overwritten during relocation, to support partial retranslation. Signed-off-by: Richard Henderson Signed-off-by: Aurelien Jarno --- tcg/hppa/tcg-target.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tcg/hppa/tcg-target.c b/tcg/hppa/tcg-target.c index 6941e22a59..6536a429f4 100644 --- a/tcg/hppa/tcg-target.c +++ b/tcg/hppa/tcg-target.c @@ -723,8 +723,11 @@ static void tcg_out_branch(TCGContext *s, int label_index, int nul) tcg_out32(s, op | reassemble_17(val)); } else { + /* We need to keep the offset unchanged for retranslation. */ + uint32_t old_insn = *(uint32_t *)s->code_ptr; + tcg_out_reloc(s, s->code_ptr, R_PARISC_PCREL17F, label_index, 0); - tcg_out32(s, op); + tcg_out32(s, op | (old_insn & 0x1f1ffdu)); } } @@ -777,11 +780,14 @@ static void tcg_out_brcond(TCGContext *s, int cond, TCGArg c1, tcg_out32(s, op | reassemble_12(val)); tcg_out_nop(s); } else { + /* We need to keep the offset unchanged for retranslation. */ + uint32_t old_insn = *(uint32_t *)s->code_ptr; + tcg_out_reloc(s, s->code_ptr, R_PARISC_PCREL12F, label_index, 0); /* ??? Assume that all branches to undefined labels are forward. Which means that if the nul bit is set, the delay slot is not executed if the branch is taken, which is what we want. */ - tcg_out32(s, op | 2); + tcg_out32(s, op | 2 | (old_insn & 0x1ffdu)); } }