mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

msi_init: change return value to 0 on success

Browse Source 
No caller use its return value as msi capability offset, also in order
to make its return behaviour consistent with msix_init().

cc: Michael S. Tsirkin <mst@redhat.com>
cc: Paolo Bonzini <pbonzini@redhat.com>
cc: Hannes Reinecke <hare@suse.de>
cc: Markus Armbruster <armbru@redhat.com>
cc: Marcel Apfelbaum <marcel@redhat.com>

Acked-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This commit is contained in:
Cao jin 2016-06-10 17:54:32 +08:00 committed by Michael S. Tsirkin
parent 52ea63dea4
commit 2cbb1a6826
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hw/pci/msi.c
View File

@ -173,8 +173,7 @@ bool msi_enabled(const PCIDevice *dev)
* If @msi64bit, make the device capable of sending a 64-bit message * If @msi64bit, make the device capable of sending a 64-bit message
* address. * address.
* If @msi_per_vector_mask, make the device support per-vector masking. * If @msi_per_vector_mask, make the device support per-vector masking.
* Return the offset of capability MSI in config space on success, * Return 0 on success, return -errno on error.
* return -errno on error.
* *
* -ENOTSUP means lacking msi support for a msi-capable platform. * -ENOTSUP means lacking msi support for a msi-capable platform.
* -EINVAL means capability overlap, happens when @offset is non-zero, * -EINVAL means capability overlap, happens when @offset is non-zero,
@ -236,7 +235,8 @@ int msi_init(struct PCIDevice *dev, uint8_t offset,
pci_set_long(dev->wmask + msi_mask_off(dev, msi64bit), pci_set_long(dev->wmask + msi_mask_off(dev, msi64bit),
0xffffffff >> (PCI_MSI_VECTORS_MAX - nr_vectors)); 0xffffffff >> (PCI_MSI_VECTORS_MAX - nr_vectors));
} }
return config_offset;
return 0;
} }
void msi_uninit(struct PCIDevice *dev) void msi_uninit(struct PCIDevice *dev)