mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pci: don't ignore invalid parameter for pci_register_bar().

Browse Source 
Abort when invalid value for region_num is passed to pci_register_bar.
That is caller's bug. Abort instead of silently ignoring invalid value.

Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This commit is contained in:
Isaku Yamahata 2010-09-09 11:48:56 +09:00 committed by Michael S. Tsirkin
parent 5a9ff3819a
commit 2bbb9c2f7f
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
hw/pci.c
View File

@ -765,9 +765,8 @@ void pci_register_bar(PCIDevice *pci_dev, int region_num,
uint32_t addr; uint32_t addr;
uint64_t wmask; uint64_t wmask;
if ((unsigned int)region_num >= PCI_NUM_REGIONS) assert(region_num >= 0);
return; assert(region_num < PCI_NUM_REGIONS);
if (size & (size-1)) { if (size & (size-1)) {
fprintf(stderr, "ERROR: PCI region size must be pow2 " fprintf(stderr, "ERROR: PCI region size must be pow2 "
"type=0x%x, size=0x%"FMT_PCIBUS"\n", type, size); "type=0x%x, size=0x%"FMT_PCIBUS"\n", type, size);