mirrors
/
qemu
mirror of https://gitlab.com/qemu-project/qemu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

slirp: Fix port comparision in slirp_remove_hostfwd 

For UDP host forwardings, fport is not stable, every outgoing packet of
the redirection can modify it. Use getsockname instead to look up the
port that is actually used on the host side.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
This commit is contained in:
Jan Kiszka 2009-06-24 14:42:28 +02:00 committed by Anthony Liguori
parent c92ef6a22d
commit 2ad82cf9e2
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
slirp/slirp.c
View File

@ -761,12 +761,16 @@ int slirp_remove_hostfwd(int is_udp, int host_port)
{ {
struct socket *so; struct socket *so;
struct socket *head = (is_udp ? &udb : &tcb); struct socket *head = (is_udp ? &udb : &tcb);
int fport = htons(host_port); struct sockaddr_in addr;
int port = htons(host_port);
socklen_t addr_len;
int n = 0; int n = 0;
loop_again: loop_again:
for (so = head->so_next; so != head; so = so->so_next) { for (so = head->so_next; so != head; so = so->so_next) {
if (so->so_fport == fport) { addr_len = sizeof(addr);
if (getsockname(so->s, (struct sockaddr *)&addr, &addr_len) == 0 &&
addr.sin_port == port) {
close(so->s); close(so->s);
sofree(so); sofree(so);
n++; n++;