mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

accel/tcg: Fix user-only probe_access_internal plugin check

Browse Source 
The acc_flag check for write should have been against PAGE_WRITE_ORG,
not PAGE_WRITE.  But it is better to combine two acc_flag checks
to a single check against access_type.  This matches the system code
in cputlb.c.

Cc: qemu-stable@nongnu.org
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2647
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: 20241111145002.144995-1-richard.henderson@linaro.org
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
This commit is contained in:
Richard Henderson 2024-11-11 06:45:40 -08:00
parent f275508046
commit 2a339fee45
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
accel/tcg/user-exec.c
View File

@ -800,7 +800,7 @@ static int probe_access_internal(CPUArchState *env, vaddr addr,
if (guest_addr_valid_untagged(addr)) { if (guest_addr_valid_untagged(addr)) {
int page_flags = page_get_flags(addr); int page_flags = page_get_flags(addr);
if (page_flags & acc_flag) { if (page_flags & acc_flag) {
if ((acc_flag == PAGE_READ || acc_flag == PAGE_WRITE) if (access_type != MMU_INST_FETCH
&& cpu_plugin_mem_cbs_enabled(env_cpu(env))) { && cpu_plugin_mem_cbs_enabled(env_cpu(env))) {
return TLB_MMIO; return TLB_MMIO;
} }