mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test-visitor-serialization: Drop insufficient precision workaround

Browse Source 
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20201210161452.2813491-10-armbru@redhat.com>
This commit is contained in:
Markus Armbruster 2020-12-10 17:14:51 +01:00
parent 54addb01d8
commit 2a02c1398a
1 changed files with 2 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
tests/test-visitor-serialization.c
View File

@ -311,17 +311,7 @@ static void test_primitives(gconstpointer opaque)
g_assert_cmpstr(pt->value.string, ==, pt_copy->value.string); g_assert_cmpstr(pt->value.string, ==, pt_copy->value.string);
g_free((char *)pt_copy->value.string); g_free((char *)pt_copy->value.string);
} else if (pt->type == PTYPE_NUMBER) { } else if (pt->type == PTYPE_NUMBER) {
GString *double_expected = g_string_new(""); g_assert_cmpfloat(pt->value.number, ==, pt_copy->value.number);
GString *double_actual = g_string_new("");
/* we serialize with %f for our reference visitors, so rather than fuzzy
* floating math to test "equality", just compare the formatted values
*/
g_string_printf(double_expected, "%.6f", pt->value.number);
g_string_printf(double_actual, "%.6f", pt_copy->value.number);
g_assert_cmpstr(double_actual->str, ==, double_expected->str);
g_string_free(double_expected, true);
g_string_free(double_actual, true);
} else if (pt->type == PTYPE_BOOLEAN) { } else if (pt->type == PTYPE_BOOLEAN) {
g_assert_cmpint(!!pt->value.max, ==, !!pt->value.max); g_assert_cmpint(!!pt->value.max, ==, !!pt->value.max);
} else { } else {
@ -703,10 +693,6 @@ static PrimitiveType pt_values[] = {
.value.boolean = 0, .value.boolean = 0,
}, },
/* number tests (double) */ /* number tests (double) */
/* note: we format these to %.6f before comparing, since that's how
* we serialize them and it doesn't make sense to check precision
* beyond that.
*/
{ {
.description = "number_sanity1", .description = "number_sanity1",
.type = PTYPE_NUMBER, .type = PTYPE_NUMBER,
@ -715,7 +701,7 @@ static PrimitiveType pt_values[] = {
{ {
.description = "number_sanity2", .description = "number_sanity2",
.type = PTYPE_NUMBER, .type = PTYPE_NUMBER,
.value.number = 3.14159265, .value.number = 3.141593,
}, },
{ {
.description = "number_min", .description = "number_min",