mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

QDict: Fix size update

Browse Source 
Key replacement should not update the dictionary's size.

This commit also adds a test for the bug.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
This commit is contained in:
Luiz Capitulino 2009-12-14 18:53:20 -02:00 committed by Anthony Liguori
parent 18dd19a7d9
commit 29ec3156ee
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
check-qdict.c
View File

@ -205,6 +205,8 @@ START_TEST(qdict_put_exists_test)
value = qdict_get_int(tests_dict, key); value = qdict_get_int(tests_dict, key);
fail_unless(value == 2); fail_unless(value == 2);
fail_unless(qdict_size(tests_dict) == 1);
} }
END_TEST END_TEST

3
qdict.c
View File

@ -122,9 +122,8 @@ void qdict_put_obj(QDict *qdict, const char *key, QObject *value)
/* allocate a new entry */ /* allocate a new entry */
entry = alloc_entry(key, value); entry = alloc_entry(key, value);
QLIST_INSERT_HEAD(&qdict->table[hash], entry, next); QLIST_INSERT_HEAD(&qdict->table[hash], entry, next);
qdict->size++;
} }
qdict->size++;
} }
/** /**