mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

s390/kvm: make TOD setting failures fatal for migration

Browse Source 
If we fail to set a proper TOD clock on the target system,  this can
already result in some problematic cases. We print several warn messages
on source and target in that case.

If kvm fails to set a nonzero epoch index, then we must ultimately fail
the migration as this will result in a giant time leap backwards. This
patch lets the migration fail if we can not set the guest time on the
target.

On failure the guest will resume normally on the original host machine.

Signed-off-by: Collin L. Walling <walling@linux.vnet.ibm.com>
Reviewed-by: Eric Farman <farman@linux.vnet.ibm.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.vnet.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
[split failure change from epoch index change, minor fixups]
Message-Id: <20171004105751.24655-3-borntraeger@de.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
This commit is contained in:
Collin L. Walling 2017-10-04 12:57:51 +02:00 committed by Cornelia Huck
parent 7edd4a4967
commit 28f8dbe85d
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
hw/s390x/s390-virtio-ccw.c
View File

@ -189,13 +189,10 @@ static int gtod_load(QEMUFile *f, void *opaque, int version_id)
r = s390_set_clock(&tod_high, &tod_low); r = s390_set_clock(&tod_high, &tod_low);
if (r) { if (r) {
warn_report("Unable to set guest clock for migration: %s", error_report("Unable to set KVM guest TOD clock: %s", strerror(-r));
strerror(-r));
error_printf("Guest clock will not be restored "
"which could cause the guest to hang.");
} }
return 0; return r;
} }
static SaveVMHandlers savevm_gtod = { static SaveVMHandlers savevm_gtod = {