mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

target/arm: Pull calls to disas_sve() and disas_sme() out of legacy decoder

Browse Source 
The SVE and SME decode is already done by decodetree.  Pull the calls
to these decoders out of the legacy decoder.  This doesn't change
behaviour because all the patterns in sve.decode and sme.decode
already require the bits that the legacy decoder is decoding to have
the correct values.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20230512144106.3608981-4-peter.maydell@linaro.org
This commit is contained in:
Peter Maydell 2023-05-12 15:40:49 +01:00
parent 8058c8316f
commit 270076d01a
1 changed files with 4 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
target/arm/tcg/translate-a64.c
View File

@ -14205,19 +14205,6 @@ static bool btype_destination_ok(uint32_t insn, bool bt, int btype)
static void disas_a64_legacy(DisasContext *s, uint32_t insn) static void disas_a64_legacy(DisasContext *s, uint32_t insn)
{ {
switch (extract32(insn, 25, 4)) { switch (extract32(insn, 25, 4)) {
case 0x0:
if (!extract32(insn, 31, 1) || !disas_sme(s, insn)) {
unallocated_encoding(s);
}
break;
case 0x1: case 0x3: /* UNALLOCATED */
unallocated_encoding(s);
break;
case 0x2:
if (!disas_sve(s, insn)) {
unallocated_encoding(s);
}
break;
case 0x8: case 0x9: /* Data processing - immediate */ case 0x8: case 0x9: /* Data processing - immediate */
disas_data_proc_imm(s, insn); disas_data_proc_imm(s, insn);
break; break;
@ -14239,7 +14226,7 @@ static void disas_a64_legacy(DisasContext *s, uint32_t insn)
disas_data_proc_simd_fp(s, insn); disas_data_proc_simd_fp(s, insn);
break; break;
default: default:
assert(FALSE); /* all 15 cases should be handled above */ unallocated_encoding(s);
break; break;
} }
} }
@ -14445,8 +14432,9 @@ static void aarch64_tr_translate_insn(DisasContextBase *dcbase, CPUState *cpu)
disas_sme_fa64(s, insn); disas_sme_fa64(s, insn);
} }
if (!disas_a64(s, insn) &&
if (!disas_a64(s, insn)) { !disas_sme(s, insn) &&
!disas_sve(s, insn)) {
disas_a64_legacy(s, insn); disas_a64_legacy(s, insn);
} }