mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gdbstub: Correct invalid mentions of 'softmmu' by 'system'

Browse Source 
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20240313213339.82071-3-philmd@linaro.org>
This commit is contained in:
Philippe Mathieu-Daudé 2024-03-13 21:09:38 +01:00
parent 93019696aa
commit 25f34eb708
2 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
gdbstub/internals.h
View File

@ -115,7 +115,7 @@ void gdb_read_byte(uint8_t ch);
/* /*
* Packet acknowledgement - we handle this slightly differently * Packet acknowledgement - we handle this slightly differently
* between user and softmmu mode, mainly to deal with the differences * between user and system mode, mainly to deal with the differences
* between the flexible chardev and the direct fd approaches. * between the flexible chardev and the direct fd approaches.
* *
* We currently don't support a negotiated QStartNoAckMode * We currently don't support a negotiated QStartNoAckMode
@ -125,7 +125,7 @@ void gdb_read_byte(uint8_t ch);
* gdb_got_immediate_ack() - check ok to continue * gdb_got_immediate_ack() - check ok to continue
* *
* Returns true to continue, false to re-transmit for user only, the * Returns true to continue, false to re-transmit for user only, the
* softmmu stub always returns true. * system stub always returns true.
*/ */
bool gdb_got_immediate_ack(void); bool gdb_got_immediate_ack(void);
/* utility helpers */ /* utility helpers */
@ -135,12 +135,12 @@ CPUState *gdb_first_attached_cpu(void);
void gdb_append_thread_id(CPUState *cpu, GString *buf); void gdb_append_thread_id(CPUState *cpu, GString *buf);
int gdb_get_cpu_index(CPUState *cpu); int gdb_get_cpu_index(CPUState *cpu);
unsigned int gdb_get_max_cpus(void); /* both */ unsigned int gdb_get_max_cpus(void); /* both */
bool gdb_can_reverse(void); /* softmmu, stub for user */ bool gdb_can_reverse(void); /* system emulation, stub for user */
int gdb_target_sigtrap(void); /* user */ int gdb_target_sigtrap(void); /* user */
void gdb_create_default_process(GDBState *s); void gdb_create_default_process(GDBState *s);
/* signal mapping, common for softmmu, specialised for user-mode */ /* signal mapping, common for system, specialised for user-mode */
int gdb_signal_to_target(int sig); int gdb_signal_to_target(int sig);
int gdb_target_signal_to_gdb(int sig); int gdb_target_signal_to_gdb(int sig);
@ -157,12 +157,12 @@ void gdb_continue(void);
int gdb_continue_partial(char *newstates); int gdb_continue_partial(char *newstates);
/* /*
* Helpers with separate softmmu and user implementations * Helpers with separate system and user implementations
*/ */
void gdb_put_buffer(const uint8_t *buf, int len); void gdb_put_buffer(const uint8_t *buf, int len);
/* /*
* Command handlers - either specialised or softmmu or user only * Command handlers - either specialised or system or user only
*/ */
void gdb_init_gdbserver_state(void); void gdb_init_gdbserver_state(void);
@ -187,7 +187,7 @@ typedef union GdbCmdVariant {
#define get_param(p, i) (&g_array_index(p, GdbCmdVariant, i)) #define get_param(p, i) (&g_array_index(p, GdbCmdVariant, i))
void gdb_handle_query_rcmd(GArray *params, void *user_ctx); /* softmmu */ void gdb_handle_query_rcmd(GArray *params, void *user_ctx); /* system */
void gdb_handle_query_offsets(GArray *params, void *user_ctx); /* user */ void gdb_handle_query_offsets(GArray *params, void *user_ctx); /* user */
void gdb_handle_query_xfer_auxv(GArray *params, void *user_ctx); /*user */ void gdb_handle_query_xfer_auxv(GArray *params, void *user_ctx); /*user */
void gdb_handle_query_xfer_siginfo(GArray *params, void *user_ctx); /*user */ void gdb_handle_query_xfer_siginfo(GArray *params, void *user_ctx); /*user */
@ -203,7 +203,7 @@ bool gdb_handle_detach_user(uint32_t pid); /* user */
void gdb_handle_query_attached(GArray *params, void *user_ctx); /* both */ void gdb_handle_query_attached(GArray *params, void *user_ctx); /* both */
/* softmmu only */ /* system only */
void gdb_handle_query_qemu_phy_mem_mode(GArray *params, void *user_ctx); void gdb_handle_query_qemu_phy_mem_mode(GArray *params, void *user_ctx);
void gdb_handle_set_qemu_phy_mem_mode(GArray *params, void *user_ctx); void gdb_handle_set_qemu_phy_mem_mode(GArray *params, void *user_ctx);
@ -213,11 +213,11 @@ bool gdb_handled_syscall(void);
void gdb_disable_syscalls(void); void gdb_disable_syscalls(void);
void gdb_syscall_reset(void); void gdb_syscall_reset(void);
/* user/softmmu specific syscall handling */ /* user/system specific syscall handling */
void gdb_syscall_handling(const char *syscall_packet); void gdb_syscall_handling(const char *syscall_packet);
/* /*
* Break/Watch point support - there is an implementation for softmmu * Break/Watch point support - there is an implementation for system
* and user mode. * and user mode.
*/ */
bool gdb_supports_guest_debug(void); bool gdb_supports_guest_debug(void);

2
gdbstub/system.c
View File

@ -1,5 +1,5 @@
/* /*
* gdb server stub - softmmu specific bits * gdb server stub - system specific bits
* *
* Debug integration depends on support from the individual * Debug integration depends on support from the individual
* accelerators so most of this involves calling the ops helpers. * accelerators so most of this involves calling the ops helpers.