mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

qapi: Make 'allow-oob' optional in SchemaInfoCommand

Browse Source 
Making 'allow-oob' optional in SchemaInfoCommand permits omitting it
in the common case.  Shrinks query-qmp-schema's output from 122.1KiB
to 118.6KiB for me.

Note that out-of-band execution is still experimental (you have to
configure the monitor with x-oob=on to use it).

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20180718090557.17248-1-armbru@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
This commit is contained in:
Markus Armbruster 2018-07-18 11:05:57 +02:00
parent 6598f0cdad
commit 25b1ef31db
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
qapi/introspect.json
View File

@ -259,8 +259,8 @@
# #
# @ret-type: the name of the command's result type. # @ret-type: the name of the command's result type.
# #
# @allow-oob: whether the command allows out-of-band execution. # @allow-oob: whether the command allows out-of-band execution,
# (Since: 2.12) # defaults to false (Since: 2.12)
# #
# TODO: @success-response (currently irrelevant, because it's QGA, not QMP) # TODO: @success-response (currently irrelevant, because it's QGA, not QMP)
# #
@ -268,7 +268,7 @@
## ##
{ 'struct': 'SchemaInfoCommand', { 'struct': 'SchemaInfoCommand',
'data': { 'arg-type': 'str', 'ret-type': 'str', 'data': { 'arg-type': 'str', 'ret-type': 'str',
'allow-oob': 'bool' } } '*allow-oob': 'bool' } }
## ##
# @SchemaInfoEvent: # @SchemaInfoEvent:

10
scripts/qapi/introspect.py
View File

@ -184,11 +184,11 @@ const QLitObject %(c_name)s = %(c_string)s;
success_response, boxed, allow_oob, allow_preconfig): success_response, boxed, allow_oob, allow_preconfig):
arg_type = arg_type or self._schema.the_empty_object_type arg_type = arg_type or self._schema.the_empty_object_type
ret_type = ret_type or self._schema.the_empty_object_type ret_type = ret_type or self._schema.the_empty_object_type
self._gen_qlit(name, 'command', obj = {'arg-type': self._use_type(arg_type),
{'arg-type': self._use_type(arg_type), 'ret-type': self._use_type(ret_type) }
'ret-type': self._use_type(ret_type), if allow_oob:
'allow-oob': allow_oob}, obj['allow-oob'] = allow_oob
ifcond) self._gen_qlit(name, 'command', obj, ifcond)
def visit_event(self, name, info, ifcond, arg_type, boxed): def visit_event(self, name, info, ifcond, arg_type, boxed):
arg_type = arg_type or self._schema.the_empty_object_type arg_type = arg_type or self._schema.the_empty_object_type