iotests/testrunner: Flush after run_test()
When stdout is not a terminal, the buffer may not be flushed at each end of line, so we should flush after each test is done. This is especially apparent when run by check-block, in two ways: First, when running make check-block -jX with X > 1, progress indication was missing, even though testrunner.py does theoretically print each test's status once it has been run, even in multi-processing mode. Flushing after each test restores this progress indication. Second, sometimes make check-block failed altogether, with an error message that "too few tests [were] run". I presume that's because one worker process in the job pool did not get to flush its stdout before the main process exited, and so meson did not get to see that worker's test results. In any case, by flushing at the end of run_test(), the problem has disappeared for me. Signed-off-by: Hanna Reitz <hreitz@redhat.com> Message-Id: <20220506134215.10086-1-hreitz@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
parent
9ec7a59b5a
commit
22d92e71c7
@ -378,6 +378,7 @@ class TestRunner(ContextManager['TestRunner']):
|
||||
else:
|
||||
print(res.casenotrun)
|
||||
|
||||
sys.stdout.flush()
|
||||
return res
|
||||
|
||||
def run_tests(self, tests: List[str], jobs: int = 1) -> bool:
|
||||
|
Loading…
Reference in New Issue
Block a user