mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

qapi-visit: Use common idiom in gen_visit_fields_decl()

Browse Source 
We have several instances of methods that do an early exit if
output is not needed, then log that output is being generated,
and finally produce the output; see qapi-types.py:gen_object()
and qapi-visit.py:gen_visit_implicit_struct().  The odd man
out was gen_visit_fields_decl(); rearrange it to be more like
the others.  No semantic change or difference to generated code.

Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1455778109-6278-12-git-send-email-eblake@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
This commit is contained in:
Eric Blake 2016-02-17 23:48:25 -07:00 committed by Markus Armbruster
parent 1de5d4ca07
commit 2208d64998
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
scripts/qapi-visit.py
View File

@ -35,15 +35,14 @@ void visit_type_%(c_name)s(Visitor *v, const char *name, %(c_type)sobj, Error **
def gen_visit_fields_decl(typ): def gen_visit_fields_decl(typ):
ret = '' if typ.name in struct_fields_seen:
if typ.name not in struct_fields_seen: return ''
ret += mcgen(''' struct_fields_seen.add(typ.name)
return mcgen('''
static void visit_type_%(c_type)s_fields(Visitor *v, %(c_type)s *obj, Error **errp); static void visit_type_%(c_type)s_fields(Visitor *v, %(c_type)s *obj, Error **errp);
''', ''',
c_type=typ.c_name()) c_type=typ.c_name())
struct_fields_seen.add(typ.name)
return ret
def gen_visit_implicit_struct(typ): def gen_visit_implicit_struct(typ):