memfd: fix possible usage of the uninitialized file descriptor
The qemu_memfd_alloc_check() routine allocates the fd variable on stack. This variable is initialized inside the qemu_memfd_alloc() function. There are several cases when *fd will be left unintialized which can lead to the unexpected close() in the qemu_memfd_free() call. Set file descriptor to -1 before calling the qemu_memfd_alloc routine. Signed-off-by: Dima Stepanov <dimastep@yandex-team.ru> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: Thomas Huth <thuth@redhat.com> Signed-off-by: Thomas Huth <thuth@redhat.com>
This commit is contained in:
parent
91c082ad86
commit
1e7ec6cf06
@ -187,6 +187,7 @@ bool qemu_memfd_alloc_check(void)
|
||||
int fd;
|
||||
void *ptr;
|
||||
|
||||
fd = -1;
|
||||
ptr = qemu_memfd_alloc("test", 4096, 0, &fd, NULL);
|
||||
memfd_check = ptr ? MEMFD_OK : MEMFD_KO;
|
||||
qemu_memfd_free(ptr, 4096, fd);
|
||||
|
Loading…
x
Reference in New Issue
Block a user