mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tests/unit/test-vmstate: Assert that dup() and mkstemp() succeed

Browse Source 
Coverity complains that we don't check for failures from dup()
and mkstemp(); add asserts that these syscalls succeeded.

Fixes: Coverity CID 1432516, 1432574
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20210525134458.6675-7-peter.maydell@linaro.org
This commit is contained in:
Peter Maydell 2021-05-25 14:44:58 +01:00
parent d2304612b5
commit 1c86188589
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tests/unit/test-vmstate.c
View File

@ -40,10 +40,12 @@ static int temp_fd;
/* Duplicate temp_fd and seek to the beginning of the file */ /* Duplicate temp_fd and seek to the beginning of the file */
static QEMUFile *open_test_file(bool write) static QEMUFile *open_test_file(bool write)
{ {
int fd = dup(temp_fd); int fd;
QIOChannel *ioc; QIOChannel *ioc;
QEMUFile *f; QEMUFile *f;
fd = dup(temp_fd);
g_assert(fd >= 0);
lseek(fd, 0, SEEK_SET); lseek(fd, 0, SEEK_SET);
if (write) { if (write) {
g_assert_cmpint(ftruncate(fd, 0), ==, 0); g_assert_cmpint(ftruncate(fd, 0), ==, 0);
@ -1486,6 +1488,7 @@ int main(int argc, char **argv)
g_autofree char *temp_file = g_strdup_printf("%s/vmst.test.XXXXXX", g_autofree char *temp_file = g_strdup_printf("%s/vmst.test.XXXXXX",
g_get_tmp_dir()); g_get_tmp_dir());
temp_fd = mkstemp(temp_file); temp_fd = mkstemp(temp_file);
g_assert(temp_fd >= 0);
module_call_init(MODULE_INIT_QOM); module_call_init(MODULE_INIT_QOM);