mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

hw/ivshmem.c don't check for negative values on unsigned data types

Browse Source 
There is no need to check for dest < 0 or vector >= 0 as both are
uint16_t.

This should fix problems with broken build with aggressive compiler
flags. Reported by Xudong Hao <xudong.hao@intel.com>

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Acked-by: Cam Macdonell <cam@cs.ualberta.ca>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
This commit is contained in:
Jes Sorensen 2010-08-30 12:31:33 +02:00 committed by Blue Swirl
parent 37a05af069
commit 1b27d7a1e8
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hw/ivshmem.c
View File

@ -199,13 +199,13 @@ static void ivshmem_io_writel(void *opaque, target_phys_addr_t addr,
case DOORBELL: case DOORBELL:
/* check that dest VM ID is reasonable */ /* check that dest VM ID is reasonable */
if ((dest < 0) || (dest > s->max_peer)) { if (dest > s->max_peer) {
IVSHMEM_DPRINTF("Invalid destination VM ID (%d)\n", dest); IVSHMEM_DPRINTF("Invalid destination VM ID (%d)\n", dest);
break; break;
} }
/* check doorbell range */ /* check doorbell range */
if ((vector >= 0) && (vector < s->peers[dest].nb_eventfds)) { if (vector < s->peers[dest].nb_eventfds) {
IVSHMEM_DPRINTF("Writing %" PRId64 " to VM %d on vector %d\n", IVSHMEM_DPRINTF("Writing %" PRId64 " to VM %d on vector %d\n",
write_one, dest, vector); write_one, dest, vector);
if (write(s->peers[dest].eventfds[vector], if (write(s->peers[dest].eventfds[vector],