mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

qmp: Use generic errors in memchar-read, memchar-write

Browse Source 
New errors should be generic unless there's a real use case for rich
errors.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
This commit is contained in:
Markus Armbruster 2013-02-06 21:27:16 +01:00 committed by Anthony Liguori
parent 3ab651fc81
commit 1a69278e53
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qapi-schema.json
View File

@ -352,7 +352,6 @@
# by default is 'utf8'. # by default is 'utf8'.
# #
# Returns: Nothing on success # Returns: Nothing on success
# If @device is not a valid char device, DeviceNotFound
# #
# Since: 1.4 # Since: 1.4
## ##
@ -374,7 +373,6 @@
# memchardev, by default is 'utf8'. # memchardev, by default is 'utf8'.
# #
# Returns: data read from the device # Returns: data read from the device
# If @device is not a valid memchr device, DeviceNotFound
# #
# Since: 1.4 # Since: 1.4
## ##

4
qemu-char.c
View File

@ -2764,7 +2764,7 @@ void qmp_memchar_write(const char *device, const char *data,
chr = qemu_chr_find(device); chr = qemu_chr_find(device);
if (!chr) { if (!chr) {
error_set(errp, QERR_DEVICE_NOT_FOUND, device); error_setg(errp, "Device '%s' not found", device);
return; return;
} }
@ -2799,7 +2799,7 @@ char *qmp_memchar_read(const char *device, int64_t size,
chr = qemu_chr_find(device); chr = qemu_chr_find(device);
if (!chr) { if (!chr) {
error_set(errp, QERR_DEVICE_NOT_FOUND, device); error_setg(errp, "Device '%s' not found", device);
return NULL; return NULL;
} }