mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

block/vmdk.o: fix warnings with _FORTIFY_SOURCE

Browse Source 
CC    block/vmdk.o
cc1: warnings being treated as errors
block/vmdk.c: In function 'vmdk_snapshot_create':
block/vmdk.c:236: error: ignoring return value of 'ftruncate', declared with attribute warn_unused_result
block/vmdk.c: In function 'vmdk_create':
block/vmdk.c:775: error: ignoring return value of 'write', declared with attribute warn_unused_result
block/vmdk.c:776: error: ignoring return value of 'write', declared with attribute warn_unused_result
block/vmdk.c:778: error: ignoring return value of 'ftruncate', declared with attribute warn_unused_result
block/vmdk.c:784: error: ignoring return value of 'write', declared with attribute warn_unused_result
block/vmdk.c:790: error: ignoring return value of 'write', declared with attribute warn_unused_result
block/vmdk.c:807: error: ignoring return value of 'write', declared with attribute warn_unused_result
make: *** [block/vmdk.o] Error 1

Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
This commit is contained in:
Kirill A. Shutemov 2010-01-20 00:56:13 +01:00 committed by Anthony Liguori
parent 3e1a8134be
commit 1640366c35
1 changed files with 40 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
block/vmdk.c
View File

@ -233,7 +233,8 @@ static int vmdk_snapshot_create(const char *filename, const char *backing_file)
memset(&header, 0, sizeof(header)); memset(&header, 0, sizeof(header));
memcpy(&header,&hdr[4], sizeof(header)); // skip the VMDK4_MAGIC memcpy(&header,&hdr[4], sizeof(header)); // skip the VMDK4_MAGIC
ftruncate(snp_fd, header.grain_offset << 9); if (ftruncate(snp_fd, header.grain_offset << 9))
goto fail;
/* the descriptor offset = 0x200 */ /* the descriptor offset = 0x200 */
if (lseek(p_fd, 0x200, SEEK_SET) == -1) if (lseek(p_fd, 0x200, SEEK_SET) == -1)
goto fail; goto fail;
@ -717,6 +718,7 @@ static int vmdk_create(const char *filename, QEMUOptionParameter *options)
int64_t total_size = 0; int64_t total_size = 0;
const char *backing_file = NULL; const char *backing_file = NULL;
int flags = 0; int flags = 0;
int ret;
// Read out options // Read out options
while (options && options->name) { while (options && options->name) {
@ -773,22 +775,44 @@ static int vmdk_create(const char *filename, QEMUOptionParameter *options)
header.check_bytes[3] = 0xa; header.check_bytes[3] = 0xa;
/* write all the data */ /* write all the data */
write(fd, &magic, sizeof(magic)); ret = qemu_write_full(fd, &magic, sizeof(magic));
write(fd, &header, sizeof(header)); if (ret != sizeof(magic)) {
ret = -1;
goto exit;
}
ret = qemu_write_full(fd, &header, sizeof(header));
if (ret != sizeof(header)) {
ret = -1;
goto exit;
}
ftruncate(fd, header.grain_offset << 9); ret = ftruncate(fd, header.grain_offset << 9);
if (ret < 0) {
ret = -1;
goto exit;
}
/* write grain directory */ /* write grain directory */
lseek(fd, le64_to_cpu(header.rgd_offset) << 9, SEEK_SET); lseek(fd, le64_to_cpu(header.rgd_offset) << 9, SEEK_SET);
for (i = 0, tmp = header.rgd_offset + gd_size; for (i = 0, tmp = header.rgd_offset + gd_size;
i < gt_count; i++, tmp += gt_size) i < gt_count; i++, tmp += gt_size) {
write(fd, &tmp, sizeof(tmp)); ret = qemu_write_full(fd, &tmp, sizeof(tmp));
if (ret != sizeof(tmp)) {
ret = -1;
goto exit;
}
}
/* write backup grain directory */ /* write backup grain directory */
lseek(fd, le64_to_cpu(header.gd_offset) << 9, SEEK_SET); lseek(fd, le64_to_cpu(header.gd_offset) << 9, SEEK_SET);
for (i = 0, tmp = header.gd_offset + gd_size; for (i = 0, tmp = header.gd_offset + gd_size;
i < gt_count; i++, tmp += gt_size) i < gt_count; i++, tmp += gt_size) {
write(fd, &tmp, sizeof(tmp)); ret = qemu_write_full(fd, &tmp, sizeof(tmp));
if (ret != sizeof(tmp)) {
ret = -1;
goto exit;
}
}
/* compose the descriptor */ /* compose the descriptor */
real_filename = filename; real_filename = filename;
@ -805,10 +829,16 @@ static int vmdk_create(const char *filename, QEMUOptionParameter *options)
/* write the descriptor */ /* write the descriptor */
lseek(fd, le64_to_cpu(header.desc_offset) << 9, SEEK_SET); lseek(fd, le64_to_cpu(header.desc_offset) << 9, SEEK_SET);
write(fd, desc, strlen(desc)); ret = qemu_write_full(fd, desc, strlen(desc));
if (ret != strlen(desc)) {
ret = -1;
goto exit;
}
ret = 0;
exit:
close(fd); close(fd);
return 0; return ret;
} }
static void vmdk_close(BlockDriverState *bs) static void vmdk_close(BlockDriverState *bs)