mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

python:QEMUMachine: template typing for self returning methods

Browse Source 
mypy thinks that return value of these methods in subclusses is
QEMUMachine, which is wrong. So, make typing smarter.

Suggested-by: John Snow <jsnow@redhat.com>
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20210824083856.17408-26-vsementsov@virtuozzo.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
This commit is contained in:
Vladimir Sementsov-Ogievskiy 2021-08-24 11:38:47 +03:00 committed by Hanna Reitz
parent 3f3c9b4c9d
commit 15c3b863ee
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
python/qemu/machine/machine.py
View File

@ -36,6 +36,7 @@ from typing import (
Sequence,
Tuple,
Type,
TypeVar,
)
from qemu.qmp import ( # pylint: disable=import-error
@ -73,6 +74,9 @@ class AbnormalShutdown(QEMUMachineError):
"""
_T = TypeVar('_T', bound='QEMUMachine')
class QEMUMachine:
"""
A QEMU VM.
@ -169,7 +173,7 @@ class QEMUMachine:
self._remove_files: List[str] = []
self._user_killed = False
def __enter__(self) -> 'QEMUMachine':
def __enter__(self: _T) -> _T:
return self
def __exit__(self,
@ -185,8 +189,8 @@ class QEMUMachine:
self._args.append('-monitor')
self._args.append('null')
def add_fd(self, fd: int, fdset: int,
opaque: str, opts: str = '') -> 'QEMUMachine':
def add_fd(self: _T, fd: int, fdset: int,
opaque: str, opts: str = '') -> _T:
"""
Pass a file descriptor to the VM
"""