mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

linux-user: Export use is_error(), use it to avoid warnings

Browse Source 
This fixes:

  linux-user/flatload.c:740:9: warning: Loss of sign in implicit conversion
      if (res > (unsigned long)-4096)
          ^~~

Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20180604153722.24956-2-f4bug@amsat.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
This commit is contained in:
Philippe Mathieu-Daudé 2018-06-04 12:37:21 -03:00 committed by Laurent Vivier
parent 9f55925b8f
commit 1129dd7121
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
linux-user/qemu.h
View File

@ -618,6 +618,11 @@ static inline void *lock_user_string(abi_ulong guest_addr)
#include <pthread.h> #include <pthread.h>
static inline int is_error(abi_long ret)
{
return (abi_ulong)ret >= (abi_ulong)(-4096);
}
/* Include target-specific struct and function definitions; /* Include target-specific struct and function definitions;
* they may need access to the target-independent structures * they may need access to the target-independent structures
* above, so include them last. * above, so include them last.

5
linux-user/syscall.c
View File

@ -906,11 +906,6 @@ static inline abi_long get_errno(abi_long ret)
return ret; return ret;
} }
static inline int is_error(abi_long ret)
{
return (abi_ulong)ret >= (abi_ulong)(-4096);
}
const char *target_strerror(int err) const char *target_strerror(int err)
{ {
if (err == TARGET_ERESTARTSYS) { if (err == TARGET_ERESTARTSYS) {